[Bug 106948] [CI] igt@* - dmesg-warn/fail - WARN_ON(dev_priv->uncore.funcs.mmio_readl(dev_priv, (((const i915_reg_t){ .reg = (0x6f900) })), true) & (1<<31))

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=106948

Chris Wilson <chris at chris-wilson.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|REOPENED                    |RESOLVED

--- Comment #17 from Chris Wilson <chris at chris-wilson.co.uk> ---
commit c12e0643a05d978657877630d4da1ace06ea3720
Author: Dhinakaran Pandiyan <dhinakaran.pandiyan at gmail.com>
Date:   Sun Jun 24 22:47:40 2018 -0700

    drm/i915/psr: Fix race in intel_psr_work()

    Commit 5422b37c907e ("drm/i915/psr: Kill delays when activating psr
    back.") switched from delayed work to the plain variant and while doing so
    removed the check for work_busy() before scheduling a PSR activation.
    This appears to cause consecutive executions of psr_activate() in this
    scenario - after a worker picks up the PSR work item for execution and
    before the work function can acquire the PSR mutex, a psr_flush() can
    get hold of the mutex and schedule another PSR work. Without a psr_exit()
    between the two psr_activate() calls, warning messages get printed.
    Further, since we drop the mutex in the midst of psr_work() to wait for
    PSR to idle, another work item can also get scheduled. Fix this by
    returning if PSR was already active.

    Fixes: 5422b37c907e ("drm/i915/psr: Kill delays when activating psr back.")
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106948
    Cc: Rodrigo Vivi <rodrigo.vivi at intel.com>
    Cc: Chris Wilson <chris at chris-wilson.co.uk>
    Cc: José Roberto de Souza <jose.souza at intel.com>
    Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan at intel.com>
    Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
    Reviewed-by: Rodrigo Vivi <rodrigo.vivi at intel.com>
    Link:
https://patchwork.freedesktop.org/patch/msgid/20180625054741.3919-1-dhinakaran.pandiyan@intel.com

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/intel-gfx-bugs/attachments/20180714/7759dc2c/attachment.html>