[Bug 107274] [CI][SHARDS] igt at gem_exec_nop@basic-parallel - incomplete - GEM_BUG_ON(!engine->i915->gt.awake)

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Wed Jul 18 12:03:18 UTC 2018


https://bugs.freedesktop.org/show_bug.cgi?id=107274

--- Comment #2 from Chris Wilson <chris at chris-wilson.co.uk> ---
It shouldn't be possible... It requires us to set gt.awake=false while the
tasklet is running, but before we do we park the engines and flush the tasklets
in the process. We must have kicked off another tasklet_schedule after
intel_engines_park.

I think...
diff --git a/drivers/gpu/drm/i915/intel_lrc.c
b/drivers/gpu/drm/i915/intel_lrc.c
index db5351e6a3a5..6921406a7250 100644
--- a/drivers/gpu/drm/i915/intel_lrc.c
+++ b/drivers/gpu/drm/i915/intel_lrc.c
@@ -1074,7 +1074,7 @@ static void execlists_submission_tasklet(unsigned long
data)

        spin_lock_irqsave(&engine->timeline.lock, flags);

-       if (engine->i915->gt.awake) /* we may be delayed until after we idle!
*/
+       if (engine->execlists.active) /* we may be delayed until after idle! */
                __execlists_submission_tasklet(engine);

        spin_unlock_irqrestore(&engine->timeline.lock, flags);

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/intel-gfx-bugs/attachments/20180718/b4235d57/attachment.html>


More information about the intel-gfx-bugs mailing list