[Bug 105012] [CI] igt at drv_selftest@live_hangcheck - Incomplete

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=105012

Chris Wilson <chris at chris-wilson.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Chris Wilson <chris at chris-wilson.co.uk> ---
Hopefully,

commit 0f36a85c3bd5e0dfcbb49af203a96a933dae86cf
Author: Chris Wilson <chris at chris-wilson.co.uk>
Date:   Thu Mar 22 07:35:33 2018 +0000

    drm/i915: Flush pending interrupt following a GPU reset

    After resetting the GPU (or subset of engines), call synchronize_irq()
    to flush any pending irq before proceeding with the cleanup. For a
    device level reset, we disable the interupts around the reset, but when
    resetting just one engine, we have to avoid such global disabling. This
    leaves us open to an interrupt arriving for the engine as we try to
    reset it. We already do try to flush the IIR following the reset, but we
    have to ensure that the in-flight interrupt does not land after we start
    cleaning up after the reset; enter synchronize_irq().

    As it current stands, we very rarely, but fatally, see sequences such as:

        2.... 57964564us : execlists_reset_prepare: rcs0
        2.... 57964613us : execlists_reset: rcs0 seqno=424
        0d.h1 57964615us : gen8_cs_irq_handler: rcs0 CS active=1
        2d..1 57964617us : __i915_request_unsubmit: rcs0 fence 29:1056 <-
global_seqno 1060
        2.... 57964703us : execlists_reset_finish: rcs0
        0..s. 57964705us : execlists_submission_tasklet: rcs0 awake?=1,
active=0, irq-posted?=1

    v2: Move the sync into the execlists reset handler so that we coordinate
    the flush with disabling the interrupt handling and canceling the
    pending interrupt.
    v3: Just use synchronize_hardirq() to avoid the might_sleep(), we do not
    yet have threaded-irq to worry about.

    Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
    Cc: Mika Kuoppala <mika.kuoppala at linux.intel.com>
    Cc: Michel Thierry <michel.thierry at intel.com>
    Cc: Michał Winiarski <michal.winiarski at intel.com>
    Cc: Jeff McGee <jeff.mcgee at intel.com>
    Link:
https://patchwork.freedesktop.org/patch/msgid/20180322073533.5313-4-chris@chris-wilson.co.uk
    Reviewed-by: Jeff McGee <jeff.mcgee at intel.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/intel-gfx-bugs/attachments/20180322/c249cfed/attachment.html>