[Bug 105720] screen corruption using SNA and TearFree on Intel GeminiLake

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=105720

--- Comment #20 from Chris Wilson <chris at chris-wilson.co.uk> ---
Based on Martin's AccelMethod=none logs, we found this:

commit 7418d53c589719f71154c5ec58a2b7c486020587 (HEAD, upstream/master)
Author: Chris Wilson <chris at chris-wilson.co.uk>
Date:   Wed Mar 28 19:38:51 2018 +0100

    sna/dri2: Clip application of damage to windowed swapbuffers

    Since forever we have been passing region=NULL when doing a windowed
    swapbuffer on vblank, and using that to mark the entire pixmap as being
    damaged. For an uncomposited window, this is incorrect as it points to a
    clipped region of the ScreenPixmap and so we were marking the entire
    ScreenPixmap as being flushed, but only having operated on the windowed
    region. Instead pass along the clip extents if region is unset.

    References: https://bugs.freedesktop.org/show_bug.cgi?id=105720
    Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>

It definitely impacts AccelMethod=none and seems to improve AccelMethod=sna as
well, but I haven't been able to explain why.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/intel-gfx-bugs/attachments/20180328/b3d0126f/attachment.html>