[Bug 106085] [CI] igt at drv_selftest@mock_breadcrumbs - breadcrumbs returned 10000, conflicting with selftest's magic values!

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=106085

Chris Wilson <chris at chris-wilson.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #5 from Chris Wilson <chris at chris-wilson.co.uk> ---
commit 77cbe925bf77bd3159f49c4db0ea89a2045d9071
Author: Chris Wilson <chris at chris-wilson.co.uk>
Date:   Tue Apr 17 18:06:38 2018 +0100

    drm/i915/selftests: Fix error checking for wait_var_timeout

    The old wait_on_atomic_t used a custom callback to perform the
    schedule(), which used my return semantics of reporting an error code on
    timeout. wait_var_event_timeout() uses the schedule() return semantics
    of reporting the remaining jiffies (1 if it timed out with 0 jiffies
    remaining!) and 0 on failure. This semantic mismatch lead to us falsely
    claiming a time out occurred.

    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106085
    Fixes: d224985a5e31 ("sched/wait, drivers/drm: Convert wait_on_atomic_t()
usage to the new wait_var_event() API")
    Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
    Reviewed-by: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>
    Reviewed-by: Mika Kuoppala <mika.kuoppala at linux.intel.com>
    Link:
https://patchwork.freedesktop.org/patch/msgid/20180417170638.20550-1-chris@chris-wilson.co.uk

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/intel-gfx-bugs/attachments/20180502/44ffa403/attachment.html>