[Bug 108642] [CI][SHARDS] igt at kms_properties@connector-properties-atomic - fail - Test assertion failure function max_bpc_prop_test, Failed assertion: ret == 0

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=108642

--- Comment #4 from Stanislav Lisovskiy <stanislav.lisovskiy at intel.com> ---
Problem is quite simple in fact. I enabled atomic debugs for recent kernel and
found that this code in drm_atomic.c is executed, thus returning EINVAL:

if (!state->allow_modeset) {
        for_each_new_crtc_in_state(state, crtc, new_crtc_state, i) {
                if (drm_atomic_crtc_needs_modeset(new_crtc_state)) {
                        DRM_DEBUG_ATOMIC("[CRTC:%d:%s] requires full
modeset\n",
                                                 crtc->base.id, crtc->name);
                        return -EINVAL;
                }
        }
}

So it determines that we have to do a full modeset, while we are not allowing
it and returns an error.

state->allow_modeset is set to false, because DRM_MODE_ATOMIC_ALLOW_MODESET bit
is not set drmModeAtomicCommit call.

Just merely adding this flag fixes the test case:

ret = drmModeAtomicCommit(fd, req,
DRM_MODE_ATOMIC_TEST_ONLY|DRM_MODE_ATOMIC_ALLOW_MODESET, NULL);

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/intel-gfx-bugs/attachments/20181128/82bfc30e/attachment.html>