[Bug 100047] [IGT][CI] Change kms_sysfs_edid_timing test into a performance test

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Fri Apr 12 12:46:46 UTC 2019


https://bugs.freedesktop.org/show_bug.cgi?id=100047

Martin Peres <martin.peres at free.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[IGT][CI]                   |[IGT][CI] Change
                   |kms_sysfs_edid_timing test  |kms_sysfs_edid_timing test
                   |Failed assertion: mean.mean |into a performance test
                   |< (THRESHOLD_TOTAL * 1e6)   |
         QA Contact|intel-gfx-bugs at lists.freede |
                   |sktop.org                   |
          Component|DRM/Intel                   |IGT

--- Comment #56 from Martin Peres <martin.peres at free.fr> ---
This test is asking the kernel to reprobe all connectors by writing 'detect' to
/sys/class/drm/$name/status, which blocks until all connectors are reprobed.
This does not verify that the state is valid or anything, it just checks the
performance.

EDID reading cannot be tested properly without controling the end-point, which
is what we already do with the igt at kms_chamelium@(dp|hdmi)-edid-read test. EDID
reading failures are anyway tested by pretty much every KMS test, which would
generate dmesg messages in case of failures.

So I agree with Petri's comment, this test does not increase our test coverage,
and we need to remove this test by making it a performance test instead.

User impact of a potentially slow EDID read is a high latency between hotplug
and changes in the Desktop Environment.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/intel-gfx-bugs/attachments/20190412/337a6649/attachment.html>


More information about the intel-gfx-bugs mailing list