[Bug 111295] [CI][SHARDS] igt at perf_pmu@* - dmesg-warn - WARNING: inconsistent lock state

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Mon Aug 19 09:17:43 UTC 2019


https://bugs.freedesktop.org/show_bug.cgi?id=111295

Lakshmi <lakshminarayana.vudum at intel.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      i915 platform|                            |BYT

--- Comment #12 from Lakshmi <lakshminarayana.vudum at intel.com> ---
(In reply to Chris Wilson from comment #10)
> commit c7302f204490f3eb4ef839bec228315bcd3ba43f (drm-intel/for-linux-next,
> drm-intel/drm-intel-next-queued)
> Author: Chris Wilson <chris at chris-wilson.co.uk>
> Date:   Thu Aug 8 21:27:58 2019 +0100
> 
>     drm/i915: Defer final intel_wakeref_put to process context
>     
>     As we need to acquire a mutex to serialise the final
>     intel_wakeref_put, we need to ensure that we are in process context at
>     that time. However, we want to allow operation on the intel_wakeref from
>     inside timer and other hardirq context, which means that need to defer
>     that final put to a workqueue.
>     
>     Inside the final wakeref puts, we are safe to operate in any context, as
>     we are simply marking up the HW and state tracking for the potential
>     sleep. It's only the serialisation with the potential sleeping getting
>     that requires careful wait avoidance. This allows us to retain the
>     immediate processing as before (we only need to sleep over the same
>     races as the current mutex_lock).
>     
>     v2: Add a selftest to ensure we exercise the code while lockdep watches.
>     v3: That test was extremely loud and complained about many things!
>     v4: Not a whale!
>     
>     Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=111295
>     References: https://bugs.freedesktop.org/show_bug.cgi?id=111245
>     References: https://bugs.freedesktop.org/show_bug.cgi?id=111256
>     Fixes: 18398904ca9e ("drm/i915: Only recover active engines")
>     Fixes: 51fbd8de87dc ("drm/i915/pmu: Atomically acquire the gt_pm
> wakeref")
>     Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
>     Cc: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
>     Cc: Mika Kuoppala <mika.kuoppala at linux.intel.com>
>     Reviewed-by: Mika Kuoppala <mika.kuoppala at linux.intel.com>
>     Link:
> https://patchwork.freedesktop.org/patch/msgid/20190808202758.10453-1-
> chris at chris-wilson.co.uk

(In reply to CI Bug Log from comment #11)
> A CI Bug Log filter associated to this bug has been updated:
> 
> {- HSW APL SKL GLK ICL: igt at perf_pmu@* - dmesg-warn - WARNING: inconsistent
> lock state -}
> {+ HSW BYT APL SKL GLK ICL: igt at perf_pmu@* - dmesg-warn - WARNING:
> inconsistent lock state +}
> 
> New failures caught by the filter:
> 
>   *
> https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_346/fi-byt-n2820/
> igt at perf_pmu@busy-hang-bcs0.html

Seen on BYT.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/intel-gfx-bugs/attachments/20190819/a81a45b0/attachment.html>


More information about the intel-gfx-bugs mailing list