[Bug 111063] [CI][SHARDS]igt at gem_busy@close-race - dmesg-fail - general protection fault: 0000 [#1] PREEMPT SMP NOPTI

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Thu Jul 4 14:41:07 UTC 2019


https://bugs.freedesktop.org/show_bug.cgi?id=111063

Chris Wilson <chris at chris-wilson.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #6 from Chris Wilson <chris at chris-wilson.co.uk> ---
commit 0c159ffef628fa94d0f4f9128e7f2b6f2b5e86ef (HEAD -> drm-intel-next-queued,
drm-intel/for-linux-next, drm-intel/drm-intel-next-queued)
Author: Chris Wilson <chris at chris-wilson.co.uk>
Date:   Wed Jul 3 19:06:01 2019 +0100

    drm/i915/gem: Defer obj->base.resv fini until RCU callback

    Since reservation_object_fini() does an immediate free, rather than
    kfree_rcu as normal, we have to delay the release until after the RCU
    grace period has elapsed (i.e. from the rcu cleanup callback) so that we
    can rely on the RCU protected access to the fences while the object is a
    zombie.

    i915_gem_busy_ioctl relies on having an RCU barrier to protect the
    reservation in order to avoid having to take a reference and strong
    memory barriers.

    v2: Order is important; only release after putting the pages!

    Fixes: c03467ba40f7 ("drm/i915/gem: Free pages before rcu-freeing the
object")
    Testcase: igt/gem_busy/close-race
    Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
    Cc: Matthew Auld <matthew.auld at intel.com>
    Reviewed-by: Mika Kuoppala <mika.kuoppala at linux.intel.com>
    Link:
https://patchwork.freedesktop.org/patch/msgid/20190703180601.10950-1-chris@chris-wilson.co.uk

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/intel-gfx-bugs/attachments/20190704/f4567b44/attachment.html>


More information about the intel-gfx-bugs mailing list