[Bug 110683] [CI][BAT] igt at i915_selftest@live_hangcheck - dmesg-fail - failed to complete request after reset

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Wed Jul 17 17:53:56 UTC 2019


https://bugs.freedesktop.org/show_bug.cgi?id=110683

Chris Wilson <chris at chris-wilson.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #6 from Chris Wilson <chris at chris-wilson.co.uk> ---
commit c30d5dc653cbc78f9b634b7b72e25057a68c527c (HEAD -> drm-intel-next-queued,
drm-intel/for-linux-next, drm-intel/drm-intel-next-queued)
Author: Chris Wilson <chris at chris-wilson.co.uk>
Date:   Tue Jul 16 13:49:28 2019 +0100

    drm/i915/gt: Push engine stopping into reset-prepare

    Push the engine stop into the back reset_prepare (where it already was!)
    This allows us to avoid dangerously setting the RING registers to 0 for
    logical contexts. If we clear the register on a live context, those
    invalid register values are recorded in the logical context state and
    replayed (with hilarious results).

    Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
    Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
    Link:
https://patchwork.freedesktop.org/patch/msgid/20190716124931.5870-2-chris@chris-wilson.co.uk

commit fff8102aaed59014cb2d8034bdca231185496b16
Author: Chris Wilson <chris at chris-wilson.co.uk>
Date:   Tue Jul 16 13:49:29 2019 +0100

    drm/i915/execlists: Process interrupted context on reset

    By stopping the rings, we may trigger an arbitration point resulting in
    a premature context-switch (i.e. a completion event before the request
    is actually complete). This clears the active context before the reset,
    but we must remember to rewind the incomplete context for replay upon
    resume.

    Fixes: 1863e3020ab5 ("drm/i915/execlists: Always reset the context's RING
registers")
    Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
    Cc: Mika Kuoppala <mika.kuoppala at linux.intel.com>
    Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
    Link:
https://patchwork.freedesktop.org/patch/msgid/20190716124931.5870-3-chris@chris-wilson.co.uk

Hopefully. The mystery of STOP_RING persisting over reset remains, but I expect
that to be mere noise; an incidental HW detail (unless it means that the reset
itself didn't happen...)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/intel-gfx-bugs/attachments/20190717/56087a82/attachment-0001.html>


More information about the intel-gfx-bugs mailing list