[Bug 110938] [CI][BAT] igt at i915_selftest@live_evict - incomplete - GEM_BUG_ON(!vma->node.allocated)

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=110938

Chris Wilson <chris at chris-wilson.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #5 from Chris Wilson <chris at chris-wilson.co.uk> ---
If I've guessed correctly, 

commit 7009db1475e9e92c823b60c2a9c1e5a3222699f0
Author: Chris Wilson <chris at chris-wilson.co.uk>
Date:   Tue Jun 18 08:41:28 2019 +0100

    drm/i915: Keep engine alive as we retire the context

    Though we pin the context first before taking the pm wakeref, during
    retire we need to unpin before dropping the pm wakeref (breaking the
    "natural" onion). During the unpin, we may need to attach a cleanup
    operation on to the engine wakeref, ergo we want to keep the engine
    awake until after the unpin.

    v2: Push the engine wakeref into the barrier so we keep the onion unwind
    ordering in the request itself

    Fixes: ce476c80b8bf ("drm/i915: Keep contexts pinned until after the next
kernel context switch")
    Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
    Cc: Mika Kuoppala <mika.kuoppala at linux.intel.com>
    Reviewed-by: Mika Kuoppala <mika.kuoppala at linux.intel.com>
    Link:
https://patchwork.freedesktop.org/patch/msgid/20190618074153.16055-1-chris@chris-wilson.co.uk

should be the right fix, and 

commit eca153603f2f020e15d071918e0daf1d56c17d29 (HEAD -> drm-intel-next-queued)
Author: Chris Wilson <chris at chris-wilson.co.uk>
Date:   Tue Jun 18 17:19:51 2019 +0100

    drm/i915: Don't dereference request if it may have been retired when
printing

    This has caught me out on countless occasions, when we retrieve a pointer
    from the submission/execlists backend, it does not carry a reference to
    the context or ring. Those are only pinned while the request is active,
    so if we see the request is already completed, it may be in the process
    of being retired and those pointers defunct.

    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110938
    Fixes: 3a068721a973 ("drm/i915: Show ring->start for the ELSP
context/request queue")
    Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
    Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
    Link:
https://patchwork.freedesktop.org/patch/msgid/20190618161951.28820-2-chris@chris-wilson.co.uk

commit 1422768fa2600442bfc4be4b1fe112bf9d6bb5cf
Author: Chris Wilson <chris at chris-wilson.co.uk>
Date:   Tue Jun 18 17:19:50 2019 +0100

    drm/i915/selftests: Flush live_evict

    Be sure to cleanup after live_evict by flushing any residual state off
    the GPU using igt_flush_test.

    Tvrtko mentioned that it is probably wise to stop repeating this ad hoc
    around the tests and implement a live test runner.

    Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
    Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
    Link:
https://patchwork.freedesktop.org/patch/msgid/20190618161951.28820-1-chris@chris-wilson.co.uk

should prevent it from re-ocurring. We will see in the morning when Tomi
reboots the affected machines...

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/intel-gfx-bugs/attachments/20190618/773cd473/attachment.html>