[Bug 109477] [regression, bisected] [i915] setting initial watermarks on gen 7 IVYBRIDGE causes blank lines on monitor

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=109477

Andrea <andreatclist at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEEDINFO                    |NEW

--- Comment #13 from Andrea <andreatclist at gmail.com> ---
(In reply to Ville Syrjala from comment #12)
> Created attachment 143441 [details] [review]
> [PATCH] drm/i915: Disable LP1+ watermarks on Lenovo Thinkpad T431s
> 
> This patch should disable LP1+ watermarks on the affected machine
> automagically. Please test and also attach the output of intel_watermarks
> when using the patch so that I can double check that everything looks
> correct.

I checked out the last drm-tip to apply the patch, but drm-tip doesn't show the
problem anymore.

The drm-tip I used:

commit 348fd7b7fa6584957fa6a5143058b3fbb319806b
Author: Chris Wilson <chris at chris-wilson.co.uk>
Date:   Fri Mar 1 18:32:47 2019 +0000

    drm-tip: 2019y-03m-01d-18h-31m-34s UTC integration manifest

The commit that seems to fix the issue is:

"drm/i915/fbdev: Actually configure untiled displays"
d179b88deb3bf6fed4991a31fd6f0f2cad21fab5

Reverting it makes the problem appear again.

intel_watermark with d179b88deb3bf6fed4991a31fd6f0f2cad21fab5 (good):
    WM_PIPE_A = 0x000b0000
    WM_PIPE_B = 0x00000000
    WM_PIPE_C = 0x00000000
       WM_LP1 = 0x84301100
       WM_LP2 = 0x90303c00
       WM_LP3 = 0xa0406600
   WM_LP1_SPR = 0x00000000
   WM_LP2_SPR = 0x00000000
   WM_LP3_SPR = 0x00000000
      ARB_CTL = 0xd6663056
     ARB_CTL2 = 0x00000000
WM_PIPE_A: primary=11, cursor=0, sprite=0
WM_PIPE_B: primary=0, cursor=0, sprite=0
WM_PIPE_C: primary=0, cursor=0, sprite=0
WM_LP1: enabled, latency=4, fbc=3, primary=17, cursor=0, sprite=0
WM_LP2: enabled, latency=16, fbc=3, primary=60, cursor=0, sprite=0
WM_LP3: enabled, latency=32, fbc=4, primary=102, cursor=0, sprite=0
Primary A trickle feed = disabled
Sprite A trickle feed = enabled
Primary B trickle feed = disabled
Sprite B trickle feed = enabled
Primary C trickle feed = enabled
Sprite C trickle feed = enabled
DDB partitioning = 1/2
FBC watermark = enabled

intel_watermark without d179b88deb3bf6fed4991a31fd6f0f2cad21fab5 (bad):
    WM_PIPE_A = 0x000b0000
    WM_PIPE_B = 0x00000000
    WM_PIPE_C = 0x00000000
       WM_LP1 = 0x84301100
       WM_LP2 = 0x90303c00
       WM_LP3 = 0xa0406600
   WM_LP1_SPR = 0x00000000
   WM_LP2_SPR = 0x00000000
   WM_LP3_SPR = 0x00000000
      ARB_CTL = 0xd6663056
     ARB_CTL2 = 0x00000000
WM_PIPE_A: primary=11, cursor=0, sprite=0
WM_PIPE_B: primary=0, cursor=0, sprite=0
WM_PIPE_C: primary=0, cursor=0, sprite=0
WM_LP1: enabled, latency=4, fbc=3, primary=17, cursor=0, sprite=0
WM_LP2: enabled, latency=16, fbc=3, primary=60, cursor=0, sprite=0
WM_LP3: enabled, latency=32, fbc=4, primary=102, cursor=0, sprite=0
Primary A trickle feed = disabled
Sprite A trickle feed = enabled
Primary B trickle feed = disabled
Sprite B trickle feed = enabled
Primary C trickle feed = disabled
Sprite C trickle feed = enabled
DDB partitioning = 1/2
FBC watermark = enabled

Primary C trickle feed is different.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/intel-gfx-bugs/attachments/20190302/ada49b6e/attachment-0001.html>