[Bug 109383] [CI][BAT] igt@*suspend* - dmesg-warn - i915->runtime_pm.wakeref_count=1 on cleanup

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Wed May 15 21:22:01 UTC 2019


https://bugs.freedesktop.org/show_bug.cgi?id=109383

Chris Wilson <chris at chris-wilson.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #11 from Chris Wilson <chris at chris-wilson.co.uk> ---
commit 4547c255f4420e20c6cda2ee4172ae68b323e695
Author: Imre Deak <imre.deak at intel.com>
Date:   Thu May 9 20:34:36 2019 +0300

    drm/i915: Add support for tracking wakerefs w/o power-on guarantee

    It's useful to track runtime PM refs that don't guarantee a device
    power-on state to the rest of the driver. One such case is holding a
    reference that will be put asynchronously, during which normal users
    without their own reference shouldn't access the HW. A follow-up patch
    will add support for disabling display power domains asynchronously
    which needs this.

    For this we can split wakeref_count into a low half-word tracking
    all references (raw-wakerefs) and a high half-word tracking
    references guaranteeing a power-on state (wakelocks).

    Follow-up patches will make use of the API added here.

    While at it add the missing docbook header for the unchecked
    display-power and runtime_pm put functions.

    No functional changes, except for printing leaked raw-wakerefs
    and wakelocks separately in intel_runtime_pm_cleanup().

    v2:
    - Track raw wakerefs/wakelocks in the low/high half-word of
      wakeref_count, instead of adding a new counter. (Chris)
    v3:
    - Add a struct_member(T, m) helper instead of open-coding it. (Chris)
    - Checkpatch indentation formatting fix.

    Cc: Chris Wilson <chris at chris-wilson.co.uk>
    Signed-off-by: Imre Deak <imre.deak at intel.com>
    Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
    Link:
https://patchwork.freedesktop.org/patch/msgid/20190509173446.31095-2-imre.deak@intel.com

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/intel-gfx-bugs/attachments/20190515/bdbfc63d/attachment.html>


More information about the intel-gfx-bugs mailing list