[Bug 110778] [CI][SHARDS] igt@* - dmesg-warn - BUG: unable to handle page fault for address
bugzilla-daemon at freedesktop.org
bugzilla-daemon at freedesktop.org
Wed May 29 21:31:32 UTC 2019
https://bugs.freedesktop.org/show_bug.cgi?id=110778
Chris Wilson <chris at chris-wilson.co.uk> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|NEW |RESOLVED
--- Comment #3 from Chris Wilson <chris at chris-wilson.co.uk> ---
I suspect fixed by
commit f27a5d91201639161d6f6e25af1c89c9cbb3cac7 (drm-intel/topic/core-for-CI,
topic/core-for-CI)
Author: Hugh Dickins <hughd at google.com>
Date: Wed May 29 09:25:40 2019 +0200
x86/fpu: Use fault_in_pages_writeable() for pre-faulting
Since commit
d9c9ce34ed5c8 ("x86/fpu: Fault-in user stack if
copy_fpstate_to_sigframe() fails")
we use get_user_pages_unlocked() to pre-faulting user's memory if a
write generates a pagefault while the handler is disabled.
This works in general and uncovered a bug as reported by Mike Rapoport.
It has been pointed out that this function may be fragile and a
simple pre-fault as in fault_in_pages_writeable() would be a better
solution. Better as in taste and simplicity: That write (as performed by
the alternative function) performs exactly the same faulting of memory
that we had before. This was suggested by Hugh Dickins and Andrew
Morton.
Use fault_in_pages_writeable() for pre-faulting of user's stack.
Fixes: d9c9ce34ed5c8 ("x86/fpu: Fault-in user stack if
copy_fpstate_to_sigframe() fails")
Suggested-by: Andrew Morton <akpm at linux-foundation.org>
Signed-off-by: Hugh Dickins <hughd at google.com>
[bigeasy: patch description]
Signed-off-by: Sebastian Andrzej Siewior <bigeasy at linutronix.de>
but this might a different issue - time will tell.
--
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/intel-gfx-bugs/attachments/20190529/0b217c14/attachment.html>
More information about the intel-gfx-bugs
mailing list