[Bug 112246] [CI][SHARDS]igt at gem_ctx_persistence@smoketest - dmesg-warn - Invalid lrc state found before submission

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=112246

Chris Wilson <chris at chris-wilson.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #3 from Chris Wilson <chris at chris-wilson.co.uk> ---
commit 31b61f0ef9af62b6404d8df5dcd2cf58f80c9f53 (HEAD -> drm-intel-next-queued,
drm-intel/drm-intel-next-queued)
Author: Chris Wilson <chris at chris-wilson.co.uk>
Date:   Mon Nov 11 13:32:05 2019 +0000

    drm/i915/execlists: Move reset_active() from schedule-out to schedule-in

    The gem_ctx_persistence/smoketest was detecting an odd coherency issue
    inside the LRC context image; that the address of the ring buffer did
    not match our associated struct intel_ring. As we set the address into
    the context image when we pin the ring buffer into place before the
    context is active, that leaves the question of where did it get
    overwritten. Either the HW context save occurred after our pin which
    would imply that our idle barriers are broken, or we overwrote the
    context image ourselves. It is only in reset_active() where we dabble
    inside the context image outside of a serialised path from schedule-out;
    but we could equally perform the operation inside schedule-in which is
    then fully serialised with the context pin -- and remains serialised by
    the engine pulse with kill_context(). (The only downside, aside from
    doing more work inside the engine->active.lock, was the plan to merge
    all the reset paths into doing their context scrubbing on schedule-out
    needs more thought.)

    Fixes: d12acee84ffb ("drm/i915/execlists: Cancel banned contexts on
schedule-out")
    Testcase: igt/gem_ctx_persistence/smoketest
    Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
    Cc: Tvrtko Ursulin <tvrtko.ursulin at linux.intel.com>
    Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
    Link:
https://patchwork.freedesktop.org/patch/msgid/20191111133205.11590-3-chris@chris-wilson.co.uk

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/intel-gfx-bugs/attachments/20191111/e5c0b34a/attachment-0001.html>