[Bug 111918] Kernel tainted even with unsupported options

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=111918

--- Comment #2 from Eero Tamminen <eero.t.tamminen at intel.com> ---
(In reply to Daniele Ceraolo Spurio from comment #1)
> The enable_guc parameter is defined as unsafe, so the kernel will be tainted
> whenever the parameter is set, no matter if the support is there or not.
>
> Just to clarify, are you requesting to avoid a taint if the parameter is set
> on a platform that does not support GuC? If that is the case, I don't think
> that is something that will match the general handling of the i915
> parameters, because for other similar parameters for other features we do
> always taint no matter the HW support (e.g. i915.enable_psr).

Tainting is supposed to indicate kernel being in specific (unsupported, unsafe
etc) state.  If the unsafe operation isn't actually done or unsafe state
enabled, still tainting the kernel seems broken.

(I.e. this is generic i915 bug, not GuC/HuC specific one.)


Btw. Looking at the taint flag used for HuC loading, that seems odd too:
  $ cat /proc/sys/kernel/tainted
  64

According to kernel documentation:
  https://www.kernel.org/doc/html/latest/admin-guide/tainted-kernels.html

That's "taint requested by userspace application", which I think is supposed to
mean user space echoing taint to "/proc/sys/kernel/tainted" file, like
described here:
  https://lwn.net/Articles/184879/

None of the documented flags quite matches GuC case though, which is currently
"unsafe feature / firmware", but wouldn't e.g. one of these flags be closer:
"kernel issued warning" (512), "staging driver was loaded" (1024), "workaround
for bug in platform firmware applied" (2048)?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/intel-gfx-bugs/attachments/20191008/82165024/attachment.html>