[Bug 111918] Kernel tainted even when given option is unsupported, with an incorrect taint flag

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=111918

--- Comment #4 from Daniele Ceraolo Spurio <daniele.ceraolospurio at intel.com> ---
Cc: i915 maintainers

The tainting flag for the unsafe parameter is implicitly selected by the params
handler (kernel/params.c), so we have no control over it from i915:

static void param_check_unsafe(const struct kernel_param *kp)
{
        if (kp->flags & KERNEL_PARAM_FL_UNSAFE) {
                pr_notice("Setting dangerous option %s - tainting kernel\n",
                          kp->name);
                add_taint(TAINT_USER, LOCKDEP_STILL_OK);
        }
}

What we could do to avoid tainting if the feature is not supported by the HW is
define all the parameters as safe and then explicitly taint if the feature is
supported in HW. I'm not sure how this fits with the general usage of
safe/unsafe parameters in the kernel though, so I'd like an ack/nak/suggestion
from the maintainers first.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/intel-gfx-bugs/attachments/20191008/c8dc9cbd/attachment.html>