[Bug 112069] [CI][BAT] : igt at i915_selftest@live_hangcheck - incomplete - GEM_BUG_ON(!assert_pending_valid(execlists, "promote"))

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=112069

Chris Wilson <chris at chris-wilson.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #5 from Chris Wilson <chris at chris-wilson.co.uk> ---
Going from the hit on bsw and assuming this the one and the same bug,

commit 93100fdeb4de5b13a7f9113ede93cd062ba779f1
Author: Chris Wilson <chris at chris-wilson.co.uk>
Date:   Thu Oct 24 00:24:43 2019 +0100

    drm/i915/selftests: Flush interrupts before disabling tasklets

    When setting up the system to perform the atomic reset, we need to
    serialise with any ongoing interrupt tasklet or else:

    <0> [472.951428] i915_sel-4442    0d..1 466527056us :
__i915_request_submit: rcs0 fence 11659:2, current 0
    <0> [472.951554] i915_sel-4442    0d..1 466527059us :
__execlists_submission_tasklet: rcs0: queue_priority_hint:-2147483648,
submit:yes
    <0> [472.951681] i915_sel-4442    0d..1 466527061us : trace_ports: rcs0:
submit { 11659:2, 0:0 }
    <0> [472.951805] i915_sel-4442    0.... 466527114us :
__igt_atomic_reset_engine: i915_reset_engine(rcs0:active) under hardirq
    <0> [472.951932] i915_sel-4442    0d... 466527115us : intel_engine_reset:
rcs0 flags=11d
    <0> [472.952056] i915_sel-4442    0d... 466527117us :
execlists_reset_prepare: rcs0: depth<-1
    <0> [472.952179] i915_sel-4442    0d... 466527119us : intel_engine_stop_cs:
rcs0
    <0> [472.952305]   <idle>-0       1..s1 466527119us : process_csb: rcs0
cs-irq head=3, tail=4
    <0> [472.952431] i915_sel-4442    0d... 466527122us : __intel_gt_reset:
engine_mask=1
    <0> [472.952557]   <idle>-0       1..s1 466527124us : process_csb: rcs0
csb[4]: status=0x00000001:0x00000000
    <0> [472.952683]   <idle>-0       1..s1 466527130us : trace_ports: rcs0:
promote { 11659:2*, 0:0 }
    <0> [472.952808] i915_sel-4442    0d... 466527131us : execlists_reset: rcs0
    <0> [472.952933] i915_sel-4442    0d..1 466527133us : process_csb: rcs0
cs-irq head=3, tail=4
    <0> [472.953059] i915_sel-4442    0d..1 466527134us : process_csb: rcs0
csb[4]: status=0x00000001:0x00000000
    <0> [472.953185] i915_sel-4442    0d..1 466527136us : trace_ports: rcs0:
preempted { 11659:2*, 0:0 }
    <0> [472.953310] i915_sel-4442    0d..1 466527150us : assert_pending_valid:
Nothing pending for promotion!
    <0> [472.953436] i915_sel-4442    0d..1 466527158us : process_csb:
process_csb:1930 GEM_BUG_ON(!assert_pending_valid(execlists, "promote"))

    We have the same CSB events being seen by process_csb() on two different
    processors. One being issued by the reset in the test, the other by the
    interrupt; this scenario is supposed to be prevented by flushing the
    interrupt tasklet with tasklet_disable() before we enter the atomic
    reset.

    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=112069
    Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
    Cc: Mika Kuoppala <mika.kuoppala at linux.intel.com>
    Reviewed-by: Mika Kuoppala <mika.kuoppala at linux.intel.com>
    Link:
https://patchwork.freedesktop.org/patch/msgid/20191023232443.17450-1-chris@chris-wilson.co.uk

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are on the CC list for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/intel-gfx-bugs/attachments/20191024/70b2404c/attachment.html>