<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - Linux 4.5 regression: FIFO underruns on Skylake" href="https://bugs.freedesktop.org/show_bug.cgi?id=94337#c3">Comment # 3</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - Linux 4.5 regression: FIFO underruns on Skylake" href="https://bugs.freedesktop.org/show_bug.cgi?id=94337">bug 94337</a> from <a class="email" href="mailto:luto@mit.edu" title="Andy Lutomirski <luto@mit.edu>"> Andy Lutomirski</a> <pre>There is some highly questionable code in here. In skl_pipe_wm_get_hw_state: temp = hw->plane_trans[pipe][PLANE_CURSOR]; skl_pipe_wm_active_state(temp, active, true, true, i, 0); by "i", do you mean PLANE_CURSOR? This bug probably doesn't matter, because if is_cursor, then i is ignored. But I'm wondering why there's an is_cursor parameter at all, given that the code appears to be identical in both cases. If PLANE_CURSOR is intended to be just like the other planes, why not either make it plane 0 or have a for_each_plane or similar that iterates over all plane indices including PLANE_CURSOR?</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the QA Contact for the bug.</li> <li>You are on the CC list for the bug.</li> <li>You are the assignee for the bug.</li> </ul> </body> </html>