<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - [BAT IGT ALL] drv_module_reload_basic fail on all platforms" href="https://bugs.freedesktop.org/show_bug.cgi?id=94736#c19">Comment # 19</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - [BAT IGT ALL] drv_module_reload_basic fail on all platforms" href="https://bugs.freedesktop.org/show_bug.cgi?id=94736">bug 94736</a> from <a class="email" href="mailto:marius.c.vlad@intel.com" title="Marius Vlad <marius.c.vlad@intel.com>"> Marius Vlad</a> <pre>My bad won't happen again. Tested with both patches (_init and _exit) and I see no warnings now: commit 50bd9fb15ccf6f013131f334cd604d783c0c3186 Author: Takashi Iwai <<a href="mailto:tiwai@suse.de">tiwai@suse.de</a>> Date: Tue Mar 29 18:48:07 2016 +0200 ALSA: hda - Fix yet another i915 pointer leftover in error path The hdac_acomp object in hdac_i915.c is left as assigned even after binding with i915 actually fails, and this leads to the WARN_ON() at the next load of the module. Bugzilla: <a class="bz_bug_link bz_status_NEW " title="NEW - [BAT IGT ALL] drv_module_reload_basic fail on all platforms" href="show_bug.cgi?id=94736">https://bugs.freedesktop.org/show_bug.cgi?id=94736</a> Signed-off-by: Takashi Iwai <<a href="mailto:tiwai@suse.de">tiwai@suse.de</a>> commit f07183a706c41c8aabef9cd711e45a4ca367aeea Author: Takashi Iwai <<a href="mailto:tiwai@suse.de">tiwai@suse.de</a>> Date: Tue Mar 29 12:29:24 2016 +0200 ALSA: hda - Clear the leftover component assignment at snd_hdac_i915_exit() The commit [d745f5e7b8b2: ALSA: hda - Add the pin / port mapping on Intel ILK and VLV] introduced a WARN_ON() to check the pointer for avoiding the double initializations. But hdac_acomp pointer wasn't cleared at snd_hdac_i915_exit(), thus after reloading the HD-audio driver, it may result in the false positive warning. This patch makes sure to clear the leftover pointer at exit. Bugzilla: <a class="bz_bug_link bz_status_NEW " title="NEW - [BAT IGT ALL] drv_module_reload_basic fail on all platforms" href="show_bug.cgi?id=94736">https://bugs.freedesktop.org/show_bug.cgi?id=94736</a> Reported-by: Daniela Doras-prodan <<a href="mailto:daniela.doras-prodan@intel.com">daniela.doras-prodan@intel.com</a>> Signed-off-by: Takashi Iwai <<a href="mailto:tiwai@suse.de">tiwai@suse.de</a>></pre> </div> <hr> You are receiving this mail because: <ul> <li>You are on the CC list for the bug.</li> <li>You are the QA Contact for the bug.</li> </ul> </body> </html>