<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:jani.nikula@intel.com" title="Jani Nikula <jani.nikula@intel.com>"> <span class="fn">Jani Nikula</span></a>
</span> changed
<a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - [BXT-P/ APL] xrandr shows DP panel as disconnect after resume from S3"
href="https://bugs.freedesktop.org/show_bug.cgi?id=93915">bug 93915</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Resolution</td>
<td>---
</td>
<td>FIXED
</td>
</tr>
<tr>
<td style="text-align:right;">Status</td>
<td>ASSIGNED
</td>
<td>RESOLVED
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - [BXT-P/ APL] xrandr shows DP panel as disconnect after resume from S3"
href="https://bugs.freedesktop.org/show_bug.cgi?id=93915#c8">Comment # 8</a>
on <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - [BXT-P/ APL] xrandr shows DP panel as disconnect after resume from S3"
href="https://bugs.freedesktop.org/show_bug.cgi?id=93915">bug 93915</a>
from <span class="vcard"><a class="email" href="mailto:jani.nikula@intel.com" title="Jani Nikula <jani.nikula@intel.com>"> <span class="fn">Jani Nikula</span></a>
</span></b>
<pre>(In reply to Matt Roper from <a href="show_bug.cgi?id=93915#c6">comment #6</a>)
<span class="quote">> (In reply to cprigent from <a href="show_bug.cgi?id=93915#c5">comment #5</a>)
> > Matt,
> > Could you add a comment when the patch is integrated. Then we will check
> > again.
>
> This patch probably won't be accepted upstream since the review feedback was
> that we should read the value from VBT rather than saving/restoring it. I
> believe someone from VPG (Sivakumar?) is working on some patches for that.
>
> The VBT solution won't work on embedded platforms that lack any kind of
> firmware that can provide a VBT, but it should work in most other cases.</span >
Pushed the VBT solution to dinq as
commit d252bf68b75792108ae2821c3a6e1cdc58e88cb9
Author: Shubhangi Shrivastava <<a href="mailto:shubhangi.shrivastava@intel.com">shubhangi.shrivastava@intel.com</a>>
Date: Thu Mar 31 16:11:47 2016 +0530
drm/i915: Set invert bit for hpd based on VBT
to make progress.
I'm closing this one as fixed, please file another bug about the non-VBT issue.
---
I've been slowly pushing towards abstracting VBT access from the rest of the
driver to hide all the gory details. For example, the above commit adds a
function to query the invert status, instead of directly accessing the VBT
data.
We already have a function init_vbt_defaults() that we call in
intel_bios_init() regardless of whether VBT is present. In this case, I could
imagine adding a function to fill in more of dev_priv->vbt with sensible data
when VBT is not present. Alternatively, the accessor functions could check if
VBT was present or not and provide the data from somewhere else.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
<li>You are the QA Contact for the bug.</li>
</ul>
</body>
</html>