<html> <head> <base href="https://bugs.freedesktop.org/"> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - [IVB bisected] assert_scanout:531 assertion 'width == info.width && height == info.height' failed" href="https://bugs.freedesktop.org/show_bug.cgi?id=95401#c8">Comment # 8</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - [IVB bisected] assert_scanout:531 assertion 'width == info.width && height == info.height' failed" href="https://bugs.freedesktop.org/show_bug.cgi?id=95401">bug 95401</a> from <a class="email" href="mailto:chris@chris-wilson.co.uk" title="Chris Wilson <chris@chris-wilson.co.uk>"> Chris Wilson</a> <pre>(In reply to Chris Bainbridge from <a href="show_bug.cgi?id=95401#c6">comment #6</a>) > Created <a href="attachment.cgi?id=123795" name="attach_123795" title="sna-Fix-assert_scanout-regression.patch">attachment 123795</a> <a href="attachment.cgi?id=123795&action=edit" title="sna-Fix-assert_scanout-regression.patch">[details]</a> <a href='page.cgi?id=splinter.html&bug=95401&attachment=123795'>[review]</a> [review] > sna-Fix-assert_scanout-regression.patch > > The issue looks like a bug in the bisected commit (the "== 0" at end of > drmIoctl line was missed), this patch reverts to the previous behaviour. I didn't even spot it when looking at the commit :( Thanks! The result would be that we didn't notice the modeset and used the old flip buffer (as the flips are reported after the change is in effect). commit ab3ab412a459a95e94707a4e39a18790ee04e6e3 Author: Chris Bainbridge <<a href="mailto:chris.bainbridge@gmail.com">chris.bainbridge@gmail.com</a>> Date: Tue May 17 07:26:10 2016 +0100 sna: Fix increment of modeset serial after applying CRTC We track how many mode sets have been made in order to detect stale flips (i.e. a sequence that crosses a mode change). This was broken by the logic inversion in setcrc in 46caee86db0f ("sna: Fix reporting of errno after setcrtc failure") References: <a class="bz_bug_link bz_status_NEW " title="NEW - [IVB bisected] assert_scanout:531 assertion 'width == info.width && height == info.height' failed" href="show_bug.cgi?id=95401">https://bugs.freedesktop.org/show_bug.cgi?id=95401</a> Signed-off-by: Chris Bainbridge <<a href="mailto:chris.bainbridge@gmail.com">chris.bainbridge@gmail.com</a>> Signed-off-by: Chris Wilson <<a href="mailto:chris@chris-wilson.co.uk">chris@chris-wilson.co.uk</a>></pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the QA Contact for the bug.</li> </ul> </body> </html>