<html> <head> <base href="https://bugs.freedesktop.org/"> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - [CHV] Backlight init fails on Surface 3 if module load order is wrong" href="https://bugs.freedesktop.org/show_bug.cgi?id=96571#c12">Comment # 12</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - [CHV] Backlight init fails on Surface 3 if module load order is wrong" href="https://bugs.freedesktop.org/show_bug.cgi?id=96571">bug 96571</a> from <a class="email" href="mailto:shobhit.kumar@intel.com" title="Shobhit <shobhit.kumar@intel.com>"> Shobhit</a> <pre>pwm_bl.c is not used and as you said is based on device tree. The code that you point in i915, I wrote based on ACPI match from drivers/mfd/intel_soc_pmic_core.c The MFD driver will add this controller to pwm_table and will call the necessary probes. This works fine as I have tested the code for pwm-crystalcove. The pwm-crc is a cell device for MFD crystal cove PMIC. In case of LPSS, my understanding is that we need to load drivers/pwm/pwm-lpss.c and drivers/pwm/pwm-lpss-platform.c which is again based on ACPI. The corresponding ID in the driver is "80860F09". So once we ensure that this is loading the glue path should be okay. I just could not test this because I don't have a device. If you can enable - CONFIG_PWM_LPSS=y CONFIG_PWM_LPSS_PLATFORM=y And use my other patches, I assumed it should work. Of course I maybe wrong, so if you have not tested this, can you test it and update me on your findings ? Basically check if in pwm-lpss-platform.c probe is being called or not.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the QA Contact for the bug.</li> <li>You are the assignee for the bug.</li> <li>You are on the CC list for the bug.</li> </ul> </body> </html>