<html> <head> <base href="https://bugs.freedesktop.org/"> </head> <body> <div> <a class="bz_bug_link bz_status_ASSIGNED " title="ASSIGNED - [BSW bisected] OglGSCloth/Lightsmark/CS/ Portal/ Half Life 2 games performance decreased by 15%-45%" href="https://bugs.freedesktop.org/show_bug.cgi?id=90112#c56">Comment # 56</a> on <a class="bz_bug_link bz_status_ASSIGNED " title="ASSIGNED - [BSW bisected] OglGSCloth/Lightsmark/CS/ Portal/ Half Life 2 games performance decreased by 15%-45%" href="https://bugs.freedesktop.org/show_bug.cgi?id=90112">bug 90112</a> from <a class="email" href="mailto:jari.tahvanainen@intel.com" title="Jari Tahvanainen <jari.tahvanainen@intel.com>"> Jari Tahvanainen</a> <pre>Proposing this bug to be resolved+closed due to commit 8d3afd7. Please comment if you disagree (or agree). IMHO: Confirming regression or fixing by executing and testing related these old bugs will not have ROI. --- Git Log data --- commit 8d3afd7d0e666b932e6fa15901e6280fe829a786 Author: Chris Wilson <<a href="mailto:chris@chris-wilson.co.uk">chris@chris-wilson.co.uk</a> Date: Thu May 21 21:01:47 2015 +0100 drm/i915: Use spinlocks for checking when to waitboost In commit 1854d5ca0dd7a9fc11243ff220a3e93fce2b4d3e Author: Chris Wilson <<a href="mailto:chris@chris-wilson.co.uk">chris@chris-wilson.co.uk</a> Date: Tue Apr 7 16:20:32 2015 +0100 drm/i915: Deminish contribution of wait-boosting from clients we removed an atomic timer based check for allowing waitboosting and moved it below the mutex taken during RPS. However, that mutex can be held for long periods of time on Vallyview/Cherryview as communication with the PCU is slow. As clients may frequently wait for results (e.g. such as tranform feedback) we introduced contention between the client and the RPS worker. We can take advantage of the RPS worker, by switching the wait boost decision to use spin locks and defer the actual reclocking to the worker. Fixes a regression of up to 45% on Baytrail and Baswell! v2 (Daniel): - Use max_freq_softlimit instead of the not-yet-merged boost frequency. - Don't inject a fake irq into the boost work, instead treat client_boost as just another legit waker. v3: Drop the now unused mask (Chris). Bugzilla: <a class="bz_bug_link bz_status_ASSIGNED " title="ASSIGNED - [BSW bisected] OglGSCloth/Lightsmark/CS/ Portal/ Half Life 2 games performance decreased by 15%-45%" href="show_bug.cgi?id=90112">https://bugs.freedesktop.org/show_bug.cgi?id=90112</a> Signed-off-by: Chris Wilson <<a href="mailto:chris@chris-wilson.co.uk">chris@chris-wilson.co.uk</a> (v1) Signed-off-by: Daniel Vetter <<a href="mailto:daniel.vetter@ffwll.ch">daniel.vetter@ffwll.ch</a> --- Eof Git Log ---</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are on the CC list for the bug.</li> <li>You are the QA Contact for the bug.</li> </ul> </body> </html>