<html>
<head>
<base href="https://bugs.freedesktop.org/">
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEEDINFO "
title="NEEDINFO - Memory leak in drm_atomic.c eventually (few days) consuming all RAM (on at least one system configuration)"
href="https://bugs.freedesktop.org/show_bug.cgi?id=98420#c5">Comment # 5</a>
on <a class="bz_bug_link
bz_status_NEEDINFO "
title="NEEDINFO - Memory leak in drm_atomic.c eventually (few days) consuming all RAM (on at least one system configuration)"
href="https://bugs.freedesktop.org/show_bug.cgi?id=98420">bug 98420</a>
from <span class="vcard"><a class="email" href="mailto:chris@chris-wilson.co.uk" title="Chris Wilson <chris@chris-wilson.co.uk>"> <span class="fn">Chris Wilson</span></a>
</span></b>
<pre>Yeah, whether or not an unref() function is NULL safe depends on whereabouts in
the kernel you are. In kernel/ it is considered bad practice to err on the side
of safety (as it encourages sloppy use, if the caller can't decide on whether
NULL is an error or not, why should the core code be nice). On the other hand,
in drivers/gpu/drm we tend to favour NULL-safe teardown functions as then we
avoid proliferation of if (!NULL) tests. You win some, you lose some.
Reposted to dri-devel@ giving you the kudos for finding and fixing the bug.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the QA Contact for the bug.</li>
<li>You are the assignee for the bug.</li>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>