<html>
<head>
<base href="https://bugs.freedesktop.org/">
</head>
<body><table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>Bug ID</th>
<td><a class="bz_bug_link
bz_status_NEW "
title="NEW - [SKL,IVB] HDMI and DP: EDID-supplied BPP is not always properly clamped."
href="https://bugs.freedesktop.org/show_bug.cgi?id=99250">99250</a>
</td>
</tr>
<tr>
<th>Summary</th>
<td>[SKL,IVB] HDMI and DP: EDID-supplied BPP is not always properly clamped.
</td>
</tr>
<tr>
<th>Product</th>
<td>DRI
</td>
</tr>
<tr>
<th>Version</th>
<td>DRI git
</td>
</tr>
<tr>
<th>Hardware</th>
<td>All
</td>
</tr>
<tr>
<th>OS</th>
<td>Linux (All)
</td>
</tr>
<tr>
<th>Status</th>
<td>NEW
</td>
</tr>
<tr>
<th>Severity</th>
<td>normal
</td>
</tr>
<tr>
<th>Priority</th>
<td>medium
</td>
</tr>
<tr>
<th>Component</th>
<td>DRM/Intel
</td>
</tr>
<tr>
<th>Assignee</th>
<td>intel-gfx-bugs@lists.freedesktop.org
</td>
</tr>
<tr>
<th>Reporter</th>
<td>sielicki@yandex.com
</td>
</tr>
<tr>
<th>QA Contact</th>
<td>intel-gfx-bugs@lists.freedesktop.org
</td>
</tr>
<tr>
<th>CC</th>
<td>intel-gfx-bugs@lists.freedesktop.org
</td>
</tr></table>
<p>
<div>
<pre>Created <span class=""><a href="attachment.cgi?id=128711" name="attach_128711" title="Patch">attachment 128711</a> <a href="attachment.cgi?id=128711&action=edit" title="Patch">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=99250&attachment=128711'>[review]</a>
Patch
-- Display connector: (such as HDMI, DP, eDP, ...)
HDMI
Seen with:
* Dell E6430 (Ivybridge i5-3340M)
* Skylake NUC6I7KYK
* Acer X233H 24-bit monitor with ability for 30-bit FRC.
# Steps to reproduce the issue.
With male-to-male HDMI cable, plug monitor into either of
these devices. Output will appear, but it is corrupt.
# How often does the steps listed above trigger the issue?
Always, with or without X, seen on framebuffer.
Does not occur when using HDMI to DVI adapter.
# What's going on?
With Ivybridge, HDMI can only ever operate in 8BPC or 12BPC.
* ( page 78:
<a href="https://01.org/sites/default/files/documentation/snb_ihd_os_vol3_part3.pdf">https://01.org/sites/default/files/documentation/snb_ihd_os_vol3_part3.pdf</a> )
With HDMI 1.3, I believe it's legal for the monitor EDID to claim a maximum BPP
of 30.
See the following chunk of code:
<span class="quote">> drivers/gpu/drm/i915/intel_hdmi.c:1308</span >
>
<span class="quote">> bool intel_hdmi_compute_config(struct intel_encoder *encoder,
> struct intel_crtc_state *pipe_config,
> struct drm_connector_state *conn_state)
> {
> ... SNIP ...</span >
>
<span class="quote">> /*
> * HDMI is either 12 or 8, so if the display lets 10bpc sneak
> * through, clamp it down. Note that g4x/vlv don't support 12bpc hdmi
> * outputs. We also need to check that the higher clock still fits
> * within limits.
> */
> if (pipe_config->pipe_bpp > 8*3 && pipe_config->has_hdmi_sink &&
> hdmi_port_clock_valid(intel_hdmi, clock_12bpc, true) == MODE_OK &&
> hdmi_12bpc_possible(pipe_config)) {
> DRM_DEBUG_KMS("picking bpc to 12 for HDMI output\n");
> desired_bpp = 12*3;</span >
>
<span class="quote">> /* Need to adjust the port link by 1.5x for 12bpc. */
> pipe_config->port_clock = clock_12bpc;
> } else {
> DRM_DEBUG_KMS("picking bpc to 8 for HDMI output\n");
> desired_bpp = 8*3;</span >
>
<span class="quote">> pipe_config->port_clock = clock_8bpc;
> }
> }</span >
That check for (pipe_bpp > 24) is not right. It needs to check that BPP is
sufficient for 12bpc (eg: >= 36) rather than check that bpp is more than
sufficient for 8bpc.
Attached patch 0001-Fix-BPP-clamping-on-HDMI.patch does that, and it fixes the
problem with this monitor on the Ivybridge laptop. Corrupt output is no longer
seen.
It does not fix the problem with the NUC6I7KYK, though. I will open another bug
for that and link to it in here.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the QA Contact for the bug.</li>
<li>You are the assignee for the bug.</li>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>