<html> <head> <base href="https://bugs.freedesktop.org/"> </head> <body> <div> <a class="bz_bug_link bz_status_RESOLVED bz_closed" title="RESOLVED NOTOURBUG - [BAT][KBL] Warning at block/blk-mq.c:2667 blk_mq_update_nr_hw_queues+0x118/0x120 in CI" href="https://bugs.freedesktop.org/show_bug.cgi?id=101022#c5">Comment # 5</a> on <a class="bz_bug_link bz_status_RESOLVED bz_closed" title="RESOLVED NOTOURBUG - [BAT][KBL] Warning at block/blk-mq.c:2667 blk_mq_update_nr_hw_queues+0x118/0x120 in CI" href="https://bugs.freedesktop.org/show_bug.cgi?id=101022">bug 101022</a> from <a class="email" href="mailto:krisman@collabora.co.uk" title="krisman@collabora.co.uk">krisman@collabora.co.uk</a> <pre>(In reply to krisman from <a href="show_bug.cgi?id=101022#c4">comment #4</a>) > (In reply to Martin Peres from <a href="show_bug.cgi?id=101022#c3">comment #3</a>) > > (In reply to krisman from <a href="show_bug.cgi?id=101022#c2">comment #2</a>) > > > Yes, this is during the nvme rescan.. I'll mark this as not our bug for now, > > > and ping Keith Busch once I confirm this is not already fixed in linux-next. > > > > > > Thanks. > > > > Any news on this? > > Hmm. forgot to get back to it once the merge window closed. > > So, I started a discussion in linux-nvme reporting the problem and looking > for suggestions. I'm also looking for a box with NVMe card so I can at > least bisect the issue. Keith suggested the following patch diff --git a/block/blk-mq.c b/block/blk-mq.c index f2224ffd..1bccced 100644 --- a/block/blk-mq.c +++ b/block/blk-mq.c @@ -2641,7 +2641,8 @@ int blk_mq_update_nr_requests(struct request_queue *q, unsigned int nr) return ret; } -void blk_mq_update_nr_hw_queues(struct blk_mq_tag_set *set, int nr_hw_queues) +static void __blk_mq_update_nr_hw_queues(struct blk_mq_tag_set *set, + int nr_hw_queues) { struct request_queue *q; @@ -2665,6 +2666,13 @@ void blk_mq_update_nr_hw_queues(struct blk_mq_tag_set *set, int nr_hw_queues) list_for_each_entry(q, &set->tag_list, tag_set_list) blk_mq_unfreeze_queue(q); } + +void blk_mq_update_nr_hw_queues(struct blk_mq_tag_set *set, int nr_hw_queues) +{ + mutex_lock(&set->tag_list_lock); + __blk_mq_update_nr_hw_queues(set, nr_hw_queues); + mutex_unlock(&set->tag_list_lock); +} EXPORT_SYMBOL_GPL(blk_mq_update_nr_hw_queues); /* Enable polling stats and return whether they were already enabled. */ If I send it to intel-gfx, will it be grabbed by the CI and tested or is there other process in place, since it is outside drivers/gpu/drm?</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the QA Contact for the bug.</li> <li>You are on the CC list for the bug.</li> </ul> </body> </html>