<html>
<head>
<base href="https://bugs.freedesktop.org/">
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEEDINFO "
title="NEEDINFO - [BAT][SKL] igt@kms_flip@basic-flip-vs-dpms produces a dmesg-fail"
href="https://bugs.freedesktop.org/show_bug.cgi?id=101167#c14">Comment # 14</a>
on <a class="bz_bug_link
bz_status_NEEDINFO "
title="NEEDINFO - [BAT][SKL] igt@kms_flip@basic-flip-vs-dpms produces a dmesg-fail"
href="https://bugs.freedesktop.org/show_bug.cgi?id=101167">bug 101167</a>
from <span class="vcard"><a class="email" href="mailto:marta.lofstedt@intel.com" title="Marta Löfstedt <marta.lofstedt@intel.com>"> <span class="fn">Marta Löfstedt</span></a>
</span></b>
<pre>(In reply to Jani Nikula from <a href="show_bug.cgi?id=101167#c10">comment #10</a>)
...
<span class="quote">>
> Even if the underlying problem is there before 9301397a63b3 ("drm/i915:
> Implement Link Rate fallback on Link training failure"), the commit makes
> the situation worse. It doesn't matter that it does the right thing
> according to the specs, the user experience matters. It's a regression.
> Either it needs to be fixed ASAP or reverted.</span >
Jani, how about a compromise just do the traing if we are not edp?
+++ b/drivers/gpu/drm/i915/intel_dp_link_training.c
@@ -308,9 +308,17 @@ void intel_dp_stop_link_train(struct intel_dp *intel_dp)
DP_TRAINING_PATTERN_DISABLE);
}
void
intel_dp_start_link_train(struct intel_dp *intel_dp)
{
struct intel_connector *intel_connector = intel_dp->attached_connector;
if (!intel_dp_link_training_clock_recovery(intel_dp))
@@ -328,10 +336,12 @@ intel_dp_start_link_train(struct intel_dp *intel_dp)
failure_handling:
DRM_DEBUG_KMS("Link Training failed at link rate = %d, lane count =
%d",
intel_dp->link_rate, intel_dp->lane_count);
- if (!intel_dp_get_link_train_fallback_values(intel_dp,
- intel_dp->link_rate,
- intel_dp->lane_count))
- /* Schedule a Hotplug Uevent to userspace to start modeset */
- schedule_work(&intel_connector->modeset_retry_work);
+ if (!is_edp(intel_dp)) {
+ if (!intel_dp_get_link_train_fallback_values(intel_dp,
+ intel_dp->link_rate,
+ intel_dp->lane_count))
+ /* Schedule a Hotplug Uevent to userspace to start modeset */
+ schedule_work(&intel_connector->modeset_retry_work);
+ }</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the QA Contact for the bug.</li>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>