<html> <head> <base href="https://bugs.freedesktop.org/"> </head> <body> <div> <a class="bz_bug_link bz_status_REOPENED " title="REOPENED - [Regression BDW] backlight flickering/display artifacting on Broadwell integrated graphics with 4.12-rc1" href="https://bugs.freedesktop.org/show_bug.cgi?id=101111#c52">Comment # 52</a> on <a class="bz_bug_link bz_status_REOPENED " title="REOPENED - [Regression BDW] backlight flickering/display artifacting on Broadwell integrated graphics with 4.12-rc1" href="https://bugs.freedesktop.org/show_bug.cgi?id=101111">bug 101111</a> from <a class="email" href="mailto:radhakrishna.sripada@intel.com" title="Radhakrishna Sripada <radhakrishna.sripada@intel.com>"> Radhakrishna Sripada</a> <pre>In the current context the code change is equivalent to the diff posted below as dev_priv->psr.enabled is a pointer to struct intel_dp. @Mark: you can use this diff to try out. diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index d3e5fdf0d2fa..dc7a6721e0dd 100644 --- a/drivers/gpu/drm/i915/intel_dp.c +++ b/drivers/gpu/drm/i915/intel_dp.c @@ -5469,11 +5469,6 @@ static void intel_dp_set_drrs_state(struct drm_i915_private *dev_priv, return; } - /* - * FIXME: This needs proper synchronization with psr state for some - * platforms that cannot have PSR and DRRS enabled at the same time. - */ - dig_port = dp_to_dig_port(intel_dp); encoder = &dig_port->base; intel_crtc = to_intel_crtc(encoder->base.crtc); @@ -5557,6 +5552,11 @@ void intel_edp_drrs_enable(struct intel_dp *intel_dp, return; } + if (dev_priv->psr.enabled != NULL) { + DRM_DEBUG_KMS("PSR active. Disabling DRRS.\n"); + return; + } + mutex_lock(&dev_priv->drrs.mutex); if (WARN_ON(dev_priv->drrs.dp)) { DRM_ERROR("DRRS already enabled\n");</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the QA Contact for the bug.</li> <li>You are on the CC list for the bug.</li> </ul> </body> </html>