<html>
<head>
<base href="https://bugs.freedesktop.org/">
</head>
<body><span class="vcard"><a class="email" href="mailto:bugs@mblankhorst.nl" title="Maarten Lankhorst <bugs@mblankhorst.nl>"> <span class="fn">Maarten Lankhorst</span></a>
</span> changed
<a class="bz_bug_link
bz_status_ASSIGNED "
title="ASSIGNED - [CI][IGT] igt@kms_atomic_transition@plane-all-transition-nonblocking Failed assertion: ret == 0"
href="https://bugs.freedesktop.org/show_bug.cgi?id=102671">bug 102671</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Status</td>
<td>NEW
</td>
<td>ASSIGNED
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_ASSIGNED "
title="ASSIGNED - [CI][IGT] igt@kms_atomic_transition@plane-all-transition-nonblocking Failed assertion: ret == 0"
href="https://bugs.freedesktop.org/show_bug.cgi?id=102671#c9">Comment # 9</a>
on <a class="bz_bug_link
bz_status_ASSIGNED "
title="ASSIGNED - [CI][IGT] igt@kms_atomic_transition@plane-all-transition-nonblocking Failed assertion: ret == 0"
href="https://bugs.freedesktop.org/show_bug.cgi?id=102671">bug 102671</a>
from <span class="vcard"><a class="email" href="mailto:bugs@mblankhorst.nl" title="Maarten Lankhorst <bugs@mblankhorst.nl>"> <span class="fn">Maarten Lankhorst</span></a>
</span></b>
<pre>Seems to occur randomly, but I probably know what's going on now.
kms_atomic_transitions.plane_all_transitions calls wm_setup_plane which
indiscriminately calls igt_plane_set_fb(plane, NULL); this is fine for planes
which were bound to the crtc, but for unbound planes we have a separate
completion event to prevent use-after-free. This is tested in the
'plane-use-after-nonblocking-unbind' subtest. When we call
igt_plane_set_fb(plane, NULL) on a disabled plane, by accident we update its
properties nonblockingly.
The unbound plane is not associated with a crtc, and thus has its own
completion event on commit.
The nonblocking update does drm_atomic_helper_wait_for_flip_done(), followed
some time later by drm_atomic_helper_commit_hw_done(). The commit_hw_done
signals the unbound planes, so if the new atomic commit runs between
wait_for_flip_done() and hw_done(), we get the -EBUSY here.
Fix is not blindly calling igt_plane_set_fb(plane, NULL) on disabled planes.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the QA Contact for the bug.</li>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>