<html> <head> <base href="https://bugs.freedesktop.org/"> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - [SKL] enable_psr=1 on 4.15 causes rapid hangs" href="https://bugs.freedesktop.org/show_bug.cgi?id=104918#c2">Comment # 2</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - [SKL] enable_psr=1 on 4.15 causes rapid hangs" href="https://bugs.freedesktop.org/show_bug.cgi?id=104918">bug 104918</a> from <a class="email" href="mailto:luto@kernel.org" title="Andy Lutomirski <luto@kernel.org>"> Andy Lutomirski</a> <pre>Created <a href="attachment.cgi?id=137145" name="attach_137145" title="Non-working fix attempt">attachment 137145</a> <a href="attachment.cgi?id=137145&action=edit" title="Non-working fix attempt">[details]</a> <a href='page.cgi?id=splinter.html&bug=104918&attachment=137145'>[review]</a> Non-working fix attempt I wrote up the attached patch. It makes the sequence of flushes and PSR activations make a lot more sense to me, although it's rather hacky. It doesn't fix the hang, though. It might fix the latency issue I was seeing, though, but it's very hard to tell when the system hangs so quickly. (Part of the hackiness is that I'm not sure that schedule_delayed_work() actually promises to wait as long as it's asked to. I suspect that a better solution would be to use timers or even to use the vblank interrupt to trigger PSR activation. mod_timer() is actually intended for this type of usage.)</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the QA Contact for the bug.</li> <li>You are on the CC list for the bug.</li> <li>You are the assignee for the bug.</li> </ul> </body> </html>