<html>
<head>
<base href="https://bugs.freedesktop.org/">
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEEDINFO "
title="NEEDINFO - ThinkPad T450 - Broadwell-U: [drm:hsw_disable_ips [i915]] *ERROR* Timed out waiting for IPS disable"
href="https://bugs.freedesktop.org/show_bug.cgi?id=107562#c15">Comment # 15</a>
on <a class="bz_bug_link
bz_status_NEEDINFO "
title="NEEDINFO - ThinkPad T450 - Broadwell-U: [drm:hsw_disable_ips [i915]] *ERROR* Timed out waiting for IPS disable"
href="https://bugs.freedesktop.org/show_bug.cgi?id=107562">bug 107562</a>
from <span class="vcard"><a class="email" href="mailto:imre.deak@intel.com" title="Imre Deak <imre.deak@intel.com>"> <span class="fn">Imre Deak</span></a>
</span></b>
<pre>Hi Diego,
sounds like a timing issue. Could you try if you can reproduce the problem with
the following patch?
diff --git a/drivers/gpu/drm/i915/intel_display.c
b/drivers/gpu/drm/i915/intel_display.c
index ad0f0e5389d9..19c4b3ff691b 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -5081,7 +5081,7 @@ void hsw_disable_ips(const struct intel_crtc_state
*crtc_state)
/* wait for pcode to finish disabling IPS, which may take up to
42ms */
if (intel_wait_for_register(dev_priv,
IPS_CTL, IPS_ENABLE, 0,
- 42))
+ 100))
DRM_ERROR("Timed out waiting for IPS disable\n");
} else {
I915_WRITE(IPS_CTL, 0);</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
<li>You are on the CC list for the bug.</li>
<li>You are the QA Contact for the bug.</li>
</ul>
</body>
</html>