<html>
<head>
<base href="https://bugs.freedesktop.org/">
</head>
<body><span class="vcard"><a class="email" href="mailto:imre.deak@intel.com" title="Imre Deak <imre.deak@intel.com>"> <span class="fn">Imre Deak</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEEDINFO "
title="NEEDINFO - [drm-tip][BISECT] drm_atomic_helper_wait_for_dependencies fails with flip_done timed out"
href="https://bugs.freedesktop.org/show_bug.cgi?id=107365">bug 107365</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">CC</td>
<td>
</td>
<td>chris@chris-wilson.co.uk, lyude@redhat.com, ville.syrjala@linux.intel.com
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEEDINFO "
title="NEEDINFO - [drm-tip][BISECT] drm_atomic_helper_wait_for_dependencies fails with flip_done timed out"
href="https://bugs.freedesktop.org/show_bug.cgi?id=107365#c6">Comment # 6</a>
on <a class="bz_bug_link
bz_status_NEEDINFO "
title="NEEDINFO - [drm-tip][BISECT] drm_atomic_helper_wait_for_dependencies fails with flip_done timed out"
href="https://bugs.freedesktop.org/show_bug.cgi?id=107365">bug 107365</a>
from <span class="vcard"><a class="email" href="mailto:imre.deak@intel.com" title="Imre Deak <imre.deak@intel.com>"> <span class="fn">Imre Deak</span></a>
</span></b>
<pre>(In reply to <a href="mailto:dmummenschanz@web.de">dmummenschanz@web.de</a> from <a href="show_bug.cgi?id=107365#c5">comment #5</a>)
<span class="quote">> Gotcha!
>
> Found the bad commit (and got a nice learning curve in working with git and
> bisecting the kernel btw. =) )
>
> <a href="https://cgit.freedesktop.org/drm-tip/commit/">https://cgit.freedesktop.org/drm-tip/commit/</a>
> ?id=afb2c4437daeed2d0c49e246ad1ad4def5d913cd
> drm/i915/ddi: Push pipe clock enabling to encoders
>
> Hope this helps.
>
> If I can provide anything else plz let me know.
>
> Regards</span >
Thanks for the bisect (also for Lyude). Could you try if the following solves
it:
commit 2fe0c446f3468ca85055ec93dd9e2524844955cd
Author: Imre Deak <<a href="mailto:imre.deak@intel.com">imre.deak@intel.com</a>>
Date: Fri Aug 31 18:28:31 2018 +0300
drm/i915/dp_mst: Fix enabling pipe clock for all streams
Signed-off-by: Imre Deak <<a href="mailto:imre.deak@intel.com">imre.deak@intel.com</a>>
diff --git a/drivers/gpu/drm/i915/intel_ddi.c
b/drivers/gpu/drm/i915/intel_ddi.c
index f3b115ce4029..dcb1a98d624d 100644
--- a/drivers/gpu/drm/i915/intel_ddi.c
+++ b/drivers/gpu/drm/i915/intel_ddi.c
@@ -2912,7 +2912,8 @@ static void intel_ddi_pre_enable_dp(struct intel_encoder
*encoder,
icl_enable_phy_clock_gating(dig_port);
- intel_ddi_enable_pipe_clock(crtc_state);
+ if (!is_mst)
+ intel_ddi_enable_pipe_clock(crtc_state);
}
static void intel_ddi_pre_enable_hdmi(struct intel_encoder *encoder,
@@ -3015,14 +3016,14 @@ static void intel_ddi_post_disable_dp(struct
intel_encoder *encoder,
bool is_mst = intel_crtc_has_type(old_crtc_state,
INTEL_OUTPUT_DP_MST);
- intel_ddi_disable_pipe_clock(old_crtc_state);
-
- /*
- * Power down sink before disabling the port, otherwise we end
- * up getting interrupts from the sink on detecting link loss.
- */
- if (!is_mst)
+ if (!is_mst) {
+ intel_ddi_disable_pipe_clock(old_crtc_state);
+ /*
+ * Power down sink before disabling the port, otherwise we end
+ * up getting interrupts from the sink on detecting link loss.
+ */
intel_dp_sink_dpms(intel_dp, DRM_MODE_DPMS_OFF);
+ }
intel_disable_ddi_buf(encoder);
diff --git a/drivers/gpu/drm/i915/intel_dp_mst.c
b/drivers/gpu/drm/i915/intel_dp_mst.c
index 352e5216cc65..77920f1a3da1 100644
--- a/drivers/gpu/drm/i915/intel_dp_mst.c
+++ b/drivers/gpu/drm/i915/intel_dp_mst.c
@@ -166,6 +166,8 @@ static void intel_mst_post_disable_dp(struct intel_encoder
*encoder,
struct intel_connector *connector =
to_intel_connector(old_conn_state->connector);
+ intel_ddi_disable_pipe_clock(old_crtc_state);
+
/* this can fail */
drm_dp_check_act_status(&intel_dp->mst_mgr);
/* and this can also fail */
@@ -249,6 +251,8 @@ static void intel_mst_pre_enable_dp(struct intel_encoder
*encoder,
I915_WRITE(DP_TP_STATUS(port), temp);
ret = drm_dp_update_payload_part1(&intel_dp->mst_mgr);
+
+ intel_ddi_enable_pipe_clock(pipe_config);
}
static void intel_mst_enable_dp(struct intel_encoder *encoder,</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the QA Contact for the bug.</li>
<li>You are on the CC list for the bug.</li>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>