<html>
<head>
<base href="https://bugs.freedesktop.org/">
</head>
<body><span class="vcard"><a class="email" href="mailto:martin.peres@free.fr" title="Martin Peres <martin.peres@free.fr>"> <span class="fn">Martin Peres</span></a>
</span> changed
<a class="bz_bug_link
bz_status_CLOSED bz_closed"
title="CLOSED FIXED - [CI][BAT] igt@drv_selftest@live_hangcheck - igt_reset_engines failed with error"
href="https://bugs.freedesktop.org/show_bug.cgi?id=107860">bug 107860</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Status</td>
<td>RESOLVED
</td>
<td>CLOSED
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_CLOSED bz_closed"
title="CLOSED FIXED - [CI][BAT] igt@drv_selftest@live_hangcheck - igt_reset_engines failed with error"
href="https://bugs.freedesktop.org/show_bug.cgi?id=107860#c6">Comment # 6</a>
on <a class="bz_bug_link
bz_status_CLOSED bz_closed"
title="CLOSED FIXED - [CI][BAT] igt@drv_selftest@live_hangcheck - igt_reset_engines failed with error"
href="https://bugs.freedesktop.org/show_bug.cgi?id=107860">bug 107860</a>
from <span class="vcard"><a class="email" href="mailto:martin.peres@free.fr" title="Martin Peres <martin.peres@free.fr>"> <span class="fn">Martin Peres</span></a>
</span></b>
<pre>(In reply to Chris Wilson from <a href="show_bug.cgi?id=107860#c5">comment #5</a>)
<span class="quote">> The last fix for live_hangcheck was
>
> commit 9e4fa01221b3230320135072ad31ea809ca31147
> Author: Chris Wilson <<a href="mailto:chris@chris-wilson.co.uk">chris@chris-wilson.co.uk</a>>
> Date: Tue Aug 28 16:27:02 2018 +0100
>
> drm/i915/execlists: Flush tasklet directly from reset-finish
>
> On finishing the reset, the intention is to restart the GPU before we
> relinquish the forcewake taken to handle the reset - the goal being the
> GPU reloads a context before it is allowed to sleep. For this purpose,
> we used tasklet_flush() which although it accomplished the goal of
> restarting the GPU, carried with it a sting in its tail: it cleared the
> TASKLET_STATE_SCHED bit. This meant that if another CPU queued a new
> request to this engine, we would clear the flag and later attempt to
> requeue the tasklet on the local CPU, breaking the per-cpu softirq
> lists.
>
> Remove the dangerous tasklet_kill() and just run the tasklet func
> directly as we know it is safe to do so (the tasklets are internally
> locked to allow mixed usage from direct submission).
>
> Signed-off-by: Chris Wilson <<a href="mailto:chris@chris-wilson.co.uk">chris@chris-wilson.co.uk</a>>
> Cc: Tvrtko Ursulin <<a href="mailto:tvrtko.ursulin@intel.com">tvrtko.ursulin@intel.com</a>>
> Cc: Mika Kuoppala <<a href="mailto:mika.kuoppala@intel.com">mika.kuoppala@intel.com</a>>
> Cc: Michel Thierry <<a href="mailto:michel.thierry@intel.com">michel.thierry@intel.com</a>>
> Cc: Joonas Lahtinen <<a href="mailto:joonas.lahtinen@linux.intel.com">joonas.lahtinen@linux.intel.com</a>>
> Reviewed-by: Mika Kuoppala <<a href="mailto:mika.kuoppala@linux.intel.com">mika.kuoppala@linux.intel.com</a>>
> Link:
> <a href="https://patchwork.freedesktop.org/patch/msgid/20180828152702.27536-1">https://patchwork.freedesktop.org/patch/msgid/20180828152702.27536-1</a>-
> <a href="mailto:chris@chris-wilson.co.uk">chris@chris-wilson.co.uk</a></span >
ACK! Thanks for documenting it :)</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the QA Contact for the bug.</li>
<li>You are on the CC list for the bug.</li>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>