<html>
<head>
<base href="https://bugs.freedesktop.org/">
</head>
<body><span class="vcard"><a class="email" href="mailto:martin.peres@free.fr" title="Martin Peres <martin.peres@free.fr>"> <span class="fn">Martin Peres</span></a>
</span> changed
<a class="bz_bug_link
bz_status_CLOSED bz_closed"
title="CLOSED FIXED - [CI][BAT] igt@gem_exec_suspend@basic-S3 RPM wakelock ref not held during HW access RIP: 0010:gen5_read32"
href="https://bugs.freedesktop.org/show_bug.cgi?id=107588">bug 107588</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Status</td>
<td>RESOLVED
</td>
<td>CLOSED
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_CLOSED bz_closed"
title="CLOSED FIXED - [CI][BAT] igt@gem_exec_suspend@basic-S3 RPM wakelock ref not held during HW access RIP: 0010:gen5_read32"
href="https://bugs.freedesktop.org/show_bug.cgi?id=107588#c7">Comment # 7</a>
on <a class="bz_bug_link
bz_status_CLOSED bz_closed"
title="CLOSED FIXED - [CI][BAT] igt@gem_exec_suspend@basic-S3 RPM wakelock ref not held during HW access RIP: 0010:gen5_read32"
href="https://bugs.freedesktop.org/show_bug.cgi?id=107588">bug 107588</a>
from <span class="vcard"><a class="email" href="mailto:martin.peres@free.fr" title="Martin Peres <martin.peres@free.fr>"> <span class="fn">Martin Peres</span></a>
</span></b>
<pre>(In reply to Chris Wilson from <a href="show_bug.cgi?id=107588#c6">comment #6</a>)
<span class="quote">> commit 4a8ab5ea0cde753b03bfefe4c98a8c4c61f46550
> Author: Chris Wilson <<a href="mailto:chris@chris-wilson.co.uk">chris@chris-wilson.co.uk</a>>
> Date: Mon Jan 14 14:21:29 2019 +0000
>
> drm/i915: Mark up Ironlake ips with rpm wakerefs
>
> Currently Ironlake operates under the assumption that rpm awake (and its
> error checking is disabled). As such, we have missed a few places where
> we
> access registers without taking the rpm wakeref and thus trigger
> warnings. intel_ips being one culprit.
>
> As this involved adding a potentially sleeping rpm_get, we have to
> rearrange the spinlocks slightly and so switch to acquiring a device-ref
> under the spinlock rather than hold the spinlock for the whole
> operation. To be consistent, we make the change in pattern common to the
> intel_ips interface even though this adds a few more atomic operations
> than necessary in a few cases.
>
> v2: Sagar noted the mb around setting mch_dev were overkill as we only
> need ordering there, and that i915_emon_status was still using
> struct_mutex for no reason, but lacked rpm.
>
> Signed-off-by: Chris Wilson <<a href="mailto:chris@chris-wilson.co.uk">chris@chris-wilson.co.uk</a>>
> Cc: Jani Nikula <<a href="mailto:jani.nikula@intel.com">jani.nikula@intel.com</a>>
> Reviewed-by: John Harrison <<a href="mailto:John.C.Harrison@Intel.com">John.C.Harrison@Intel.com</a>>
> Link:
> <a href="https://patchwork.freedesktop.org/patch/msgid/20190114142129.24398-21">https://patchwork.freedesktop.org/patch/msgid/20190114142129.24398-21</a>-
> <a href="mailto:chris@chris-wilson.co.uk">chris@chris-wilson.co.uk</a></span >
Thanks, it did the trick!</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
<li>You are the QA Contact for the bug.</li>
</ul>
</body>
</html>