<html> <head> <base href="https://bugs.freedesktop.org/"> </head> <body> <div> <a class="bz_bug_link bz_status_RESOLVED bz_closed" title="RESOLVED FIXED - [CI][DRMTIP] igt@pm_rps@reset - dmesg-fail - Failed assertion: __gem_execbuf_wr(fd, execbuf) == 0" href="https://bugs.freedesktop.org/show_bug.cgi?id=109606#c5">Comment # 5</a> on <a class="bz_bug_link bz_status_RESOLVED bz_closed" title="RESOLVED FIXED - [CI][DRMTIP] igt@pm_rps@reset - dmesg-fail - Failed assertion: __gem_execbuf_wr(fd, execbuf) == 0" href="https://bugs.freedesktop.org/show_bug.cgi?id=109606">bug 109606</a> from <a class="email" href="mailto:martin.peres@free.fr" title="Martin Peres <martin.peres@free.fr>"> Martin Peres</a> <pre>(In reply to Chris Wilson from <a href="show_bug.cgi?id=109606#c4">comment #4</a>) > commit 89531e7d8ee8602b2723431a581250d5d0ec2913 > Author: Chris Wilson <<a href="mailto:chris@chris-wilson.co.uk">chris@chris-wilson.co.uk</a>> > Date: Tue Feb 26 09:49:19 2019 +0000 > > drm/i915: Replace global_seqno with a hangcheck heartbeat seqno > > To determine whether an engine has 'stuck', we simply check whether or > not is still on the same seqno for several seconds. To keep this simple > mechanism intact over the loss of a global seqno, we can simply add a > new global heartbeat seqno instead. As we cannot know the sequence in > which requests will then be completed, we use a primitive random number > generator instead (with a cycle long enough to not matter over an > interval of a few thousand requests between hangcheck samples). > > The alternative to using a dedicated seqno on every request is to issue > a heartbeat request and query its progress through the system. Sadly > this requires us to reduce struct_mutex so that we can issue requests > without requiring that bkl. > > v2: And without the extra CS_STALL for the hangcheck seqno -- we don't > need strict serialisation with what comes later, we just need to be sure > we don't write the hangcheck seqno before our batch is flushed. > > Signed-off-by: Chris Wilson <<a href="mailto:chris@chris-wilson.co.uk">chris@chris-wilson.co.uk</a>> > Cc: Tvrtko Ursulin <<a href="mailto:tvrtko.ursulin@intel.com">tvrtko.ursulin@intel.com</a>> > Reviewed-by: Tvrtko Ursulin <<a href="mailto:tvrtko.ursulin@intel.com">tvrtko.ursulin@intel.com</a>> > Link: > <a href="https://patchwork.freedesktop.org/patch/msgid/20190226094922.31617-1">https://patchwork.freedesktop.org/patch/msgid/20190226094922.31617-1</a>- > <a href="mailto:chris@chris-wilson.co.uk">chris@chris-wilson.co.uk</a> Fair-enough! Thanks!</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the assignee for the bug.</li> <li>You are the QA Contact for the bug.</li> <li>You are on the CC list for the bug.</li> </ul> </body> </html>