<html> <head> <base href="https://bugs.freedesktop.org/"> </head> <body> <div> <a class="bz_bug_link bz_status_CLOSED bz_closed" title="CLOSED WORKSFORME - [BAT][PNV,BLB] i915_reset_device timed out, cancelling all in-flight rendering. provokes a dmesg-warn" href="https://bugs.freedesktop.org/show_bug.cgi?id=101600#c11">Comment # 11</a> on <a class="bz_bug_link bz_status_CLOSED bz_closed" title="CLOSED WORKSFORME - [BAT][PNV,BLB] i915_reset_device timed out, cancelling all in-flight rendering. provokes a dmesg-warn" href="https://bugs.freedesktop.org/show_bug.cgi?id=101600">bug 101600</a> from <a class="email" href="mailto:martin.peres@free.fr" title="Martin Peres <martin.peres@free.fr>"> Martin Peres</a> <pre>(In reply to Chris Wilson from <a href="show_bug.cgi?id=101600#c10">comment #10</a>) > dmesg spam be silenced (by avoiding the mutex deadlock in this and only this > scenario): > > commit 8d52e447807b350b98ffb4e64bc2fcc1f181c5be > Author: Chris Wilson <<a href="mailto:chris@chris-wilson.co.uk">chris@chris-wilson.co.uk</a>> > Date: Sat Jun 23 11:39:51 2018 +0100 > > drm/i915: Defer modeset cleanup to a secondary task > > If we avoid cleaning up the old state immediately in > intel_atomic_commit_tail() and defer it to a second task, we can avoid > taking heavily contended locks when the caller is ready to procede. > Subsequent modesets will wait for the cleanup operation (either directly > via the ordered modeset wq or indirectly through the atomic helperr) > which keeps the number of inflight cleanup tasks in check. > > As an example, during reset an immediate modeset is performed to disable > the displays before the HW is reset, which must avoid struct_mutex to > avoid recursion. Moving the cleanup to a separate task, defers acquiring > the struct_mutex to after the GPU is running again, allowing it to > complete. Even in a few patches time (optimist!) when we no longer > require struct_mutex to unpin the framebuffers, it will still be good > practice to minimise the number of contention points along reset. The > mutex dependency still exists (as one modeset flushes the other), but in > the short term it resolves the deadlock for simple reset cases. > > Bugzilla: <a class="bz_bug_link bz_status_CLOSED bz_closed" title="CLOSED WORKSFORME - [BAT][PNV,BLB] i915_reset_device timed out, cancelling all in-flight rendering. provokes a dmesg-warn" href="show_bug.cgi?id=101600">https://bugs.freedesktop.org/show_bug.cgi?id=101600</a> > Signed-off-by: Chris Wilson <<a href="mailto:chris@chris-wilson.co.uk">chris@chris-wilson.co.uk</a>> > Link: > <a href="https://patchwork.freedesktop.org/patch/msgid/20180623103951.23889-1">https://patchwork.freedesktop.org/patch/msgid/20180623103951.23889-1</a>- > <a href="mailto:chris@chris-wilson.co.uk">chris@chris-wilson.co.uk</a> > Acked-by: Maarten Lankhorst <<a href="mailto:maarten.lankhorst@linux.intel.com">maarten.lankhorst@linux.intel.com</a>> > Acked-by: Daniel Vetter <<a href="mailto:daniel.vetter@ffwll.ch">daniel.vetter@ffwll.ch</a>> Thanks! Closing!</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are on the CC list for the bug.</li> <li>You are the assignee for the bug.</li> <li>You are the QA Contact for the bug.</li> </ul> </body> </html>