<html>
    <head>
      <base href="https://bugs.freedesktop.org/">
    </head>
    <body>
      <p>
        <div>
            <b><a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - REGRESSION: black screen with linux 5.0 when starting X"
   href="https://bugs.freedesktop.org/show_bug.cgi?id=109959#c56">Comment # 56</a>
              on <a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - REGRESSION: black screen with linux 5.0 when starting X"
   href="https://bugs.freedesktop.org/show_bug.cgi?id=109959">bug 109959</a>
              from <span class="vcard"><a class="email" href="mailto:adamw@happyassassin.net" title="Adam Williamson <adamw@happyassassin.net>"> <span class="fn">Adam Williamson</span></a>
</span></b>
        <pre>I tried a build of 5.0.6 with Mark's 'corrected' patch, but it fails to build
on i686 at least:

BUILDSTDERR: drivers/gpu/drm/i915/intel_dp.c: In function
'intel_dp_uses_max_link_params':
BUILDSTDERR: drivers/gpu/drm/i915/intel_dp.c:467:43: error: parameter name
omitted
BUILDSTDERR:   467 | static bool intel_dp_uses_max_link_params(struct
intel_dp*,
BUILDSTDERR:       |                                           ^~~~~~~~~~~~~~~~
BUILDSTDERR: drivers/gpu/drm/i915/intel_dp.c:471:22: error: 'intel_dp'
undeclared (first use in this function)
BUILDSTDERR:   471 |  return link_rate == intel_dp->max_link_rate &&
BUILDSTDERR:       |                      ^~~~~~~~
BUILDSTDERR: drivers/gpu/drm/i915/intel_dp.c:471:22: note: each undeclared
identifier is reported only once for each function it appears in
BUILDSTDERR: drivers/gpu/drm/i915/intel_dp.c: At top level:
BUILDSTDERR: drivers/gpu/drm/i915/intel_dp.c:475:13: error: redefinition of
'intel_dp_uses_max_link_params'
BUILDSTDERR:   475 | static bool intel_dp_uses_max_link_params(struct intel_dp
*intel_dp,
BUILDSTDERR:       |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
BUILDSTDERR: drivers/gpu/drm/i915/intel_dp.c:467:13: note: previous definition
of 'intel_dp_uses_max_link_params' was here
BUILDSTDERR:   467 | static bool intel_dp_uses_max_link_params(struct
intel_dp*,
BUILDSTDERR:       |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
BUILDSTDERR: drivers/gpu/drm/i915/intel_dp.c:467:13: warning:
'intel_dp_uses_max_link_params' defined but not used [-Wunused-function]
BUILDSTDERR: make[4]: *** [scripts/Makefile.build:277:
drivers/gpu/drm/i915/intel_dp.o] Error 1
BUILDSTDERR: make[3]: *** [scripts/Makefile.build:492: drivers/gpu/drm/i915]
Error 2
BUILDSTDERR: make[3]: *** Waiting for unfinished jobs....</pre>
        </div>
      </p>


      <hr>
      <span>You are receiving this mail because:</span>

      <ul>
          <li>You are the QA Contact for the bug.</li>
          <li>You are on the CC list for the bug.</li>
      </ul>
    </body>
</html>