<html>
<head>
<base href="https://bugs.freedesktop.org/">
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - [CI][SHARDS] igt@gem_ctx_param@invalid-param-set - fail - Failed assertion: __gem_context_set_param(fd, &arg) == -22"
href="https://bugs.freedesktop.org/show_bug.cgi?id=109674#c5">Comment # 5</a>
on <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - [CI][SHARDS] igt@gem_ctx_param@invalid-param-set - fail - Failed assertion: __gem_context_set_param(fd, &arg) == -22"
href="https://bugs.freedesktop.org/show_bug.cgi?id=109674">bug 109674</a>
from <span class="vcard"><a class="email" href="mailto:martin.peres@free.fr" title="Martin Peres <martin.peres@free.fr>"> <span class="fn">Martin Peres</span></a>
</span></b>
<pre>(In reply to Chris Wilson from <a href="show_bug.cgi?id=109674#c4">comment #4</a>)
<span class="quote">> commit 2551ed1864985d2fe1c250337f86c7b2bc670c67 (upstream/master,
> origin/master, origin/HEAD)
> Author: Chris Wilson <<a href="mailto:chris@chris-wilson.co.uk">chris@chris-wilson.co.uk</a>>
> Date: Mon Feb 18 12:25:50 2019 +0000
>
> i915/gem_ctx_param: Remove kneecapping
>
> The invalid set/get tests do not serve the purpose of detecting whether
> or not invalid parameters are indeed detected correctly -- simply because
> the kernel is the arbiter of what is invalid and this test second
> guesses that and is wrong.
>
> The intent of this test was to ensure that we didn't include any holes
> in the parameter space that may have been used for nefarious undisclosed
> purposes, i.e. the maintainer's job backed up by reviewers.
>
> As proving no holes is impossible without fuzzing/exhaustive search and
> a whitelist, accept defeat and just check whether the very last
> parameter (which should be unused for a long, long time) is invalid.
>
> Signed-off-by: Chris Wilson <<a href="mailto:chris@chris-wilson.co.uk">chris@chris-wilson.co.uk</a>>
> Cc: Joonas Lahtinen <<a href="mailto:joonas.lahtinen@linux.intel.com">joonas.lahtinen@linux.intel.com</a>>
> Reviewed-by: Tvrtko Ursulin <<a href="mailto:tvrtko.ursulin@intel.com">tvrtko.ursulin@intel.com</a>></span >
Thanks, it definitely fixed the issues. It used to be 100% reproducible but not
anymore. Last seen on CI_DRM_5814_full (1 week, 1 day old).</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the QA Contact for the bug.</li>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>