<html> <head> <base href="https://bugs.freedesktop.org/"> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - [CI][BAT] boot - aborted - *ERROR* mismatch in pipe_bpp (expected 24, found 0)" href="https://bugs.freedesktop.org/show_bug.cgi?id=109516#c4">Comment # 4</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - [CI][BAT] boot - aborted - *ERROR* mismatch in pipe_bpp (expected 24, found 0)" href="https://bugs.freedesktop.org/show_bug.cgi?id=109516">bug 109516</a> from <a class="email" href="mailto:jwrdegoede@fedoraproject.org" title="Hans de Goede <jwrdegoede@fedoraproject.org>"> Hans de Goede</a> <pre>(In reply to Jani Nikula from <a href="show_bug.cgi?id=109516#c3">comment #3</a>) > commit ca0b04db14a51893322a2a4638a41dc79c2cf98a > Author: Hans de Goede <<a href="mailto:hdegoede@redhat.com">hdegoede@redhat.com</a>> > Date: Sat Dec 1 12:31:45 2018 +0100 > > drm/i915/dsi: Fix pipe_bpp for handling for 6 bpc pixel-formats > > stops reading the pipe_bpp from hardware in DSI encoder->get_config hook. > This is required for BXT/GLK DSI. Weird, I would expect pipe_config->pipe_bpp to get set from get_pipe_config in intel_display.c and for 6bpp color formats this should not be overriden with mipi_dsi_pixel_format_to_bpp(fmt) because there the pipe_bpp may be different from dsi bpp (when dsi is using sparse 6bpp, so 6bpp packed in 24 bits per pixel). But I only tested on BYT and CHT hardware, so if this chunk: --- a/drivers/gpu/drm/i915/vlv_dsi.c +++ b/drivers/gpu/drm/i915/vlv_dsi.c @@ -1059,10 +1064,8 @@ static void bxt_dsi_get_pipe_config(struct intel_encoder *encoder, } fmt = I915_READ(MIPI_DSI_FUNC_PRG(port)) & VID_MODE_FORMAT_MASK; - pipe_config->pipe_bpp = - mipi_dsi_pixel_format_to_bpp( - pixel_format_from_register_bits(fmt)); - bpp = pipe_config->pipe_bpp; + bpp = mipi_dsi_pixel_format_to_bpp( + pixel_format_from_register_bits(fmt)); /* Enable Frame time stamo based scanline reporting */ adjusted_mode->private_flags |= Needs to be reverted that is fine with me. I'm afraid I'm totally swamped with other stuff. Jani can you do a patch reverting that chunk and then see of it makes the test-case in question happy again?</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are on the CC list for the bug.</li> <li>You are the QA Contact for the bug.</li> <li>You are the assignee for the bug.</li> </ul> </body> </html>