<html>
<head>
<base href="https://bugs.freedesktop.org/">
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [CI][SHARDS] igt@kms_plane_scaling@pipe-[abc]-scaler-with-pixel-format - fail - Failed assertion: (__kms_addfb(fb->fd, fb->gem_handle, fb->width,... , fb->modifier, fb->strides, fb->offsets, fb->num_planes, flags, &fb->fb_id)) == 0"
href="https://bugs.freedesktop.org/show_bug.cgi?id=110369#c7">Comment # 7</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [CI][SHARDS] igt@kms_plane_scaling@pipe-[abc]-scaler-with-pixel-format - fail - Failed assertion: (__kms_addfb(fb->fd, fb->gem_handle, fb->width,... , fb->modifier, fb->strides, fb->offsets, fb->num_planes, flags, &fb->fb_id)) == 0"
href="https://bugs.freedesktop.org/show_bug.cgi?id=110369">bug 110369</a>
from <span class="vcard"><a class="email" href="mailto:mika.kahola@intel.com" title="Mika Kahola <mika.kahola@intel.com>"> <span class="fn">Mika Kahola</span></a>
</span></b>
<pre>It seems that by adding igt_plane_has_format_mod() check didn't cure the
problem. Earlier I proposed a patch to add kernel supported formats on 90/270
rotation check. Maybe we could reconsider adding this check on igt test?
diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c
index 3364073c..2d47c14b 100644
--- a/tests/kms_plane_scaling.c
+++ b/tests/kms_plane_scaling.c
@@ -176,9 +176,25 @@ static const igt_rotation_t rotations[] = {
static bool can_rotate(data_t *d, unsigned format)
{
- if (format == DRM_FORMAT_C8 ||
- (intel_gen(d->devid) < 11 && format == DRM_FORMAT_RGB565))
+ switch (format) {
+ case DRM_FORMAT_RGB565:
+ if (intel_gen(d->devid) >= 11)
+ break;
+ /* fall through */
+ case DRM_FORMAT_C8:
+ case DRM_FORMAT_XRGB16161616F:
+ case DRM_FORMAT_XBGR16161616F:
+ case DRM_FORMAT_ARGB16161616F:
+ case DRM_FORMAT_ABGR16161616F:
+ case DRM_FORMAT_Y210:
+ case DRM_FORMAT_Y212:
+ case DRM_FORMAT_Y216:
+ case DRM_FORMAT_XVYU12_16161616:
+ case DRM_FORMAT_XVYU16161616:
return false;
+ default:
+ break;
+ }
return true;
}
--
2.17.1</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the QA Contact for the bug.</li>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>