<html> <head> <base href="https://bugs.freedesktop.org/"> </head> <body> <div> <a class="bz_bug_link bz_status_RESOLVED bz_closed" title="RESOLVED FIXED - [CI][SHARDS] igt@gem_exec_schedule@semaphore-codependency - fail - Failed assertion: !"GPU hung"" href="https://bugs.freedesktop.org/show_bug.cgi?id=110380#c5">Comment # 5</a> on <a class="bz_bug_link bz_status_RESOLVED bz_closed" title="RESOLVED FIXED - [CI][SHARDS] igt@gem_exec_schedule@semaphore-codependency - fail - Failed assertion: !"GPU hung"" href="https://bugs.freedesktop.org/show_bug.cgi?id=110380">bug 110380</a> from <a class="email" href="mailto:martin.peres@free.fr" title="Martin Peres <martin.peres@free.fr>"> Martin Peres</a> <pre>(In reply to Chris Wilson from <a href="show_bug.cgi?id=110380#c4">comment #4</a>) > commit b7404c7ecb38b66f103cec694e23a8e99252829e (HEAD -> > drm-intel-next-queued, drm-intel/for-linux-next, > drm-intel/drm-intel-next-queued) > Author: Chris Wilson <<a href="mailto:chris@chris-wilson.co.uk">chris@chris-wilson.co.uk</a>> > Date: Tue Apr 9 16:29:22 2019 +0100 > > drm/i915: Bump ready tasks ahead of busywaits > > Consider two tasks that are running in parallel on a pair of engines > (vcs0, vcs1), but then must complete on a shared engine (rcs0). To > maximise throughput, we want to run the first ready task on rcs0 (i.e. > the first task that completes on either of vcs0 or vcs1). When using > semaphores, however, we will instead queue onto rcs in submission order. > > To resolve this incorrect ordering, we want to re-evaluate the priority > queue when each of the request is ready. Normally this happens because > we only insert into the priority queue requests that are ready, but with > semaphores we are inserting ahead of their readiness and to compensate > we penalize those tasks with reduced priority (so that tasks that do not > need to busywait should naturally be run first). However, given a series > of tasks that each use semaphores, the queue degrades into submission > fifo rather than readiness fifo, and so to counter this we give a small > boost to semaphore users as their dependent tasks are completed (and so > we no longer require any busywait prior to running the user task as they > are then ready themselves). > > v2: Fixup irqsave for schedule_lock (Tvrtko) > > Testcase: igt/gem_exec_schedule/semaphore-codependency > Signed-off-by: Chris Wilson <<a href="mailto:chris@chris-wilson.co.uk">chris@chris-wilson.co.uk</a>> > Cc: Tvrtko Ursulin <<a href="mailto:tvrtko.ursulin@intel.com">tvrtko.ursulin@intel.com</a>> > Cc: Dmitry Rogozhkin <<a href="mailto:dmitry.v.rogozhkin@intel.com">dmitry.v.rogozhkin@intel.com</a>> > Cc: Dmitry Ermilov <<a href="mailto:dmitry.ermilov@intel.com">dmitry.ermilov@intel.com</a>> > Reviewed-by: Tvrtko Ursulin <<a href="mailto:tvrtko.ursulin@intel.com">tvrtko.ursulin@intel.com</a>> > Link: > <a href="https://patchwork.freedesktop.org/patch/msgid/20190409152922.23894-1">https://patchwork.freedesktop.org/patch/msgid/20190409152922.23894-1</a>- > <a href="mailto:chris@chris-wilson.co.uk">chris@chris-wilson.co.uk</a> Thanks, this definitely fixed the issue! It used to fail multiple times per run (~3) and now not seen in 36 runs.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are on the CC list for the bug.</li> <li>You are the QA Contact for the bug.</li> <li>You are the assignee for the bug.</li> </ul> </body> </html>