<html> <head> <base href="https://bugs.freedesktop.org/"> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - Split "assert (a && b)" statements into "assert(a); assert(b)", for more precise diagnostics" href="https://bugs.freedesktop.org/show_bug.cgi?id=110678#c1">Comment # 1</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - Split "assert (a && b)" statements into "assert(a); assert(b)", for more precise diagnostics" href="https://bugs.freedesktop.org/show_bug.cgi?id=110678">bug 110678</a> from <a class="email" href="mailto:chris@chris-wilson.co.uk" title="Chris Wilson <chris@chris-wilson.co.uk>"> Chris Wilson</a> <pre>Whereas I agree with the sentiment, my spot checking shows that logical tests have been split which do not provide any more information. They do not provide any of the information that is provided in the trace, and are basically a means to narrow down the trace. These asserts should never be enabled by default, or at any time other than during debugging as they actively destabilize the system by breaking on the first sign of error that would otherwise be handed normally. They *cause* data loss. Since you are debugging, going one step further to enable the trace or attach gdb and inspect the values is not onerous. So I have to say the patch is mere churn that doesn't improve debugging one iota.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the QA Contact for the bug.</li> </ul> </body> </html>