<html>
<head>
<base href="https://bugs.freedesktop.org/">
</head>
<body><span class="vcard"><a class="email" href="mailto:ville.syrjala@linux.intel.com" title="Ville Syrjala <ville.syrjala@linux.intel.com>"> <span class="fn">Ville Syrjala</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEEDINFO "
title="NEEDINFO - Regression: EDP panel flickers with linux 5.1+"
href="https://bugs.freedesktop.org/show_bug.cgi?id=110675">bug 110675</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Status</td>
<td>NEW
</td>
<td>NEEDINFO
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEEDINFO "
title="NEEDINFO - Regression: EDP panel flickers with linux 5.1+"
href="https://bugs.freedesktop.org/show_bug.cgi?id=110675#c9">Comment # 9</a>
on <a class="bz_bug_link
bz_status_NEEDINFO "
title="NEEDINFO - Regression: EDP panel flickers with linux 5.1+"
href="https://bugs.freedesktop.org/show_bug.cgi?id=110675">bug 110675</a>
from <span class="vcard"><a class="email" href="mailto:ville.syrjala@linux.intel.com" title="Ville Syrjala <ville.syrjala@linux.intel.com>"> <span class="fn">Ville Syrjala</span></a>
</span></b>
<pre>(In reply to theli.ua from <a href="show_bug.cgi?id=110675#c6">comment #6</a>)
<span class="quote">> Proposed hack doesn't change the outcome - it still flickers.
>
> However, if I change it to the opposite - ie to always take min_t path then
> that seem to fix the flickering.</span >
That is strange.
The new 5.1 log still shows:
[ 12.292716] [drm:intel_dump_pipe_config] dp m_n: lanes: 2; gmch_m: 5146655,
gmch_n: 8388608, link_m: 285925, link_n: 524288, tu: 64
[ 12.292717] [drm:intel_dump_pipe_config] dp m2_n2: lanes: 2; gmch_m: 16044,
gmch_n: 32768, link_m: 14261, link_n: 32768, tu: 64
which does not make any sense to me. The N values should all be 0x8000 for both
dp_m_n and dp_m2_n2.
Can you try something like this so we can maybe see what's going on?
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -6916,8 +6916,12 @@ static void compute_m_n(unsigned int m, unsigned int n,
else
*ret_n = min_t(unsigned int, roundup_pow_of_two(n),
DATA_LINK_N_MAX);
+ DRM_DEBUG_KMS("N = %d, constant_n = %d\n", *ret_n, constant_n);
+
*ret_m = div_u64((u64)m * *ret_n, n);
intel_reduce_m_n_ratio(ret_m, ret_n);
+
+ DRM_DEBUG_KMS("final N = %d, constant_n = %d\n", *ret_n, constant_n);
}
void</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
<li>You are on the CC list for the bug.</li>
<li>You are the QA Contact for the bug.</li>
</ul>
</body>
</html>