<html>
<head>
<base href="https://bugs.freedesktop.org/">
</head>
<body><span class="vcard"><a class="email" href="mailto:chris@chris-wilson.co.uk" title="Chris Wilson <chris@chris-wilson.co.uk>"> <span class="fn">Chris Wilson</span></a>
</span> changed
<a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - [CI][BAT][guc] igt@*(suspend|s3)* - dmesg-warn - Unexpected event: no suitable handler"
href="https://bugs.freedesktop.org/show_bug.cgi?id=110943">bug 110943</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Status</td>
<td>REOPENED
</td>
<td>RESOLVED
</td>
</tr>
<tr>
<td style="text-align:right;">Resolution</td>
<td>---
</td>
<td>FIXED
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - [CI][BAT][guc] igt@*(suspend|s3)* - dmesg-warn - Unexpected event: no suitable handler"
href="https://bugs.freedesktop.org/show_bug.cgi?id=110943#c17">Comment # 17</a>
on <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - [CI][BAT][guc] igt@*(suspend|s3)* - dmesg-warn - Unexpected event: no suitable handler"
href="https://bugs.freedesktop.org/show_bug.cgi?id=110943">bug 110943</a>
from <span class="vcard"><a class="email" href="mailto:chris@chris-wilson.co.uk" title="Chris Wilson <chris@chris-wilson.co.uk>"> <span class="fn">Chris Wilson</span></a>
</span></b>
<pre>commit 9be02fde93e5b564663f10a48f19159fba718e3d (HEAD -> drm-intel-next-queued,
drm-intel/for-linux-next, drm-intel/drm-intel-next-queued)
Author: Fernando Pacheco <<a href="mailto:fernando.pacheco@intel.com">fernando.pacheco@intel.com</a>>
Date: Thu Aug 29 10:41:53 2019 -0700
drm/i915/uc: Extract common code from GuC stop/disable comm
During normal driver unload we attempt to disable GuC communication
while it is currently stopped. This results in a nop'd call to
intel_guc_ct_disable within guc_disable_communication because
stop/disable rely on the same flag to prevent further comms with CT.
We can avoid the call to disable and still leave communication in a
satisfactory state by extracting a set of shared steps from stop/disable.
This set can include guc_disable_interrupts as we do not require the
single caller of guc_stop_communication to be atomic:
"drm/i915/selftests: Fixup atomic reset checking".
This situation (stop -> disable) only occurs during intel_uc_fini_hw,
so during fini, call guc_disable_communication only if currently enabled.
The symmetric calls to enable/disable remain unmodified for all other
scenarios.
Bugzilla: <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - [CI][BAT][guc] igt@*(suspend|s3)* - dmesg-warn - Unexpected event: no suitable handler"
href="show_bug.cgi?id=110943">https://bugs.freedesktop.org/show_bug.cgi?id=110943</a>
Signed-off-by: Fernando Pacheco <<a href="mailto:fernando.pacheco@intel.com">fernando.pacheco@intel.com</a>>
Cc: Chris Wilson <<a href="mailto:chris@chris-wilson.co.uk">chris@chris-wilson.co.uk</a>>
Cc: Michal Wajdeczko <<a href="mailto:michal.wajdeczko@intel.com">michal.wajdeczko@intel.com</a>>
Cc: Daniele Ceraolo Spurio <<a href="mailto:daniele.ceraolospurio@intel.com">daniele.ceraolospurio@intel.com</a>>
Reviewed-by: Daniele Ceraolo Spurio <<a href="mailto:daniele.ceraolospurio@intel.com">daniele.ceraolospurio@intel.com</a>>
Signed-off-by: Chris Wilson <<a href="mailto:chris@chris-wilson.co.uk">chris@chris-wilson.co.uk</a>>
Link:
<a href="https://patchwork.freedesktop.org/patch/msgid/20190829174154.14675-1-fernando.pacheco@intel.com">https://patchwork.freedesktop.org/patch/msgid/20190829174154.14675-1-fernando.pacheco@intel.com</a></pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
<li>You are the QA Contact for the bug.</li>
</ul>
</body>
</html>