<html>
<head>
<base href="https://bugs.freedesktop.org/">
</head>
<body><span class="vcard"><a class="email" href="mailto:matthew.d.roper@intel.com" title="Matt Roper <matthew.d.roper@intel.com>"> <span class="fn">Matt Roper</span></a>
</span> changed
<a class="bz_bug_link
bz_status_ASSIGNED "
title="ASSIGNED - [CI] igt@pm_lpsp@edp-panel-fitter - fail - Failed assertion: c->count_modes && c->modes[0].vdisplay > 768"
href="https://bugs.freedesktop.org/show_bug.cgi?id=106602">bug 106602</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Status</td>
<td>NEW
</td>
<td>ASSIGNED
</td>
</tr>
<tr>
<td style="text-align:right;">Assignee</td>
<td>intel-gfx-bugs@lists.freedesktop.org
</td>
<td>matthew.d.roper@intel.com
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_ASSIGNED "
title="ASSIGNED - [CI] igt@pm_lpsp@edp-panel-fitter - fail - Failed assertion: c->count_modes && c->modes[0].vdisplay > 768"
href="https://bugs.freedesktop.org/show_bug.cgi?id=106602#c5">Comment # 5</a>
on <a class="bz_bug_link
bz_status_ASSIGNED "
title="ASSIGNED - [CI] igt@pm_lpsp@edp-panel-fitter - fail - Failed assertion: c->count_modes && c->modes[0].vdisplay > 768"
href="https://bugs.freedesktop.org/show_bug.cgi?id=106602">bug 106602</a>
from <span class="vcard"><a class="email" href="mailto:matthew.d.roper@intel.com" title="Matt Roper <matthew.d.roper@intel.com>"> <span class="fn">Matt Roper</span></a>
</span></b>
<pre>This failure looks like an issue with the test program. The problematic code
is this section:
/* This is one of the modes Xorg creates for panels, so
* it should work just fine. Notice that Gens that
* support LPSP are too new for panels with native
* 1024x768 resolution, so this should force the panel
* fitter. */
igt_assert(c->count_modes &&
c->modes[0].hdisplay > 1024);
igt_assert(c->count_modes &&
c->modes[0].vdisplay > 768);
mode = &std_1024_mode;
There are a few problems here:
* The platform being tested here has a 13x7 panel which fails the second
assert above, even though the panel fitter would still have been used. We
should check hdisplay and vdisplay together to avoid this.
* If we do come across a true 1024x768 panel on a platform with LPSP we should
be skipping this test, not marking it as a failure. I.e., igt_require() rather
than igt_assert().
I think this patch should fix the failure:
<a href="https://patchwork.freedesktop.org/series/66015/">https://patchwork.freedesktop.org/series/66015/</a></pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
<li>You are the QA Contact for the bug.</li>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>