<html>
<head>
<base href="https://bugs.freedesktop.org/">
</head>
<body><span class="vcard"><a class="email" href="mailto:chris@chris-wilson.co.uk" title="Chris Wilson <chris@chris-wilson.co.uk>"> <span class="fn">Chris Wilson</span></a>
</span> changed
<a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - commit c1132367 "Extract GT render sleep (rc6) management" prevents entering s2idle"
href="https://bugs.freedesktop.org/show_bug.cgi?id=111909">bug 111909</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Status</td>
<td>NEW
</td>
<td>RESOLVED
</td>
</tr>
<tr>
<td style="text-align:right;">Resolution</td>
<td>---
</td>
<td>FIXED
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - commit c1132367 "Extract GT render sleep (rc6) management" prevents entering s2idle"
href="https://bugs.freedesktop.org/show_bug.cgi?id=111909#c19">Comment # 19</a>
on <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - commit c1132367 "Extract GT render sleep (rc6) management" prevents entering s2idle"
href="https://bugs.freedesktop.org/show_bug.cgi?id=111909">bug 111909</a>
from <span class="vcard"><a class="email" href="mailto:chris@chris-wilson.co.uk" title="Chris Wilson <chris@chris-wilson.co.uk>"> <span class="fn">Chris Wilson</span></a>
</span></b>
<pre>commit 82e0c5bbd6eb1d274b5a3e519ff0ab91f1f8e537 (HEAD -> drm-intel-next-queued,
drm-intel/drm-intel-next-queued)
Author: Don Hiatt <<a href="mailto:don.hiatt@intel.com">don.hiatt@intel.com</a>>
Date: Fri Nov 15 15:15:38 2019 -0800
drm/i915/guc: Skip suspend/resume GuC action on platforms w/o GuC
submission
On some platforms (e.g. KBL) that do not support GuC submission, but
the user enabled the GuC communication (e.g for HuC authentication)
calling the GuC EXIT_S_STATE action results in lose of ability to
enter RC6. We can remove the GuC suspend/resume entirely as we do
not need to save the GuC submission status.
Add intel_guc_submission_is_enabled() function to determine if
GuC submission is active.
v2: Do not suspend/resume the GuC on platforms that do not support
Guc Submission.
v3: Fix typo, move suspend logic to remove goto.
v4: Use intel_guc_submission_is_enabled() to check GuC submission
status.
v5: No need to look at engine to determine if submission is enabled.
Squash fix + intel_guc_submission_is_enabled() patch into one.
v6: Move resume check into intel_guc_resume() for symmetry.
Fix commit Fixes tag.
Reported-by: KiteStramuort <<a href="mailto:kitestramuort@autistici.org">kitestramuort@autistici.org</a>>
Reported-by: S. Zharkoff <<a href="mailto:s.zharkoff@gmail.com">s.zharkoff@gmail.com</a>>
Bugzilla: <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - [guc/huc] Deep Package C-states never reached after laptop screen is turned off"
href="show_bug.cgi?id=111594">https://bugs.freedesktop.org/show_bug.cgi?id=111594</a>
Bugzilla: <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - No package C-states on Dell XPS 15 9570 after resume from deep sleep"
href="show_bug.cgi?id=111623">https://bugs.freedesktop.org/show_bug.cgi?id=111623</a>
Fixes: ffd5ce22faa4 ("drm/i915/guc: Updates for GuC 32.0.3 firmware")
Cc: Michal Wajdeczko <<a href="mailto:michal.wajdeczko@intel.com">michal.wajdeczko@intel.com</a>>
Cc: Daniele Ceralo Spurio <<a href="mailto:daniele.ceraolospurio@intel.com">daniele.ceraolospurio@intel.com</a>>
Cc: Stuart Summers <<a href="mailto:stuart.summers@intel.com">stuart.summers@intel.com</a>>
Cc: Chris Wilson <<a href="mailto:chris@chris-wilson.co.uk">chris@chris-wilson.co.uk</a>>
Tested-by: Tomas Janousek <<a href="mailto:tomi@nomi.cz">tomi@nomi.cz</a>>
Signed-off-by: Don Hiatt <<a href="mailto:don.hiatt@intel.com">don.hiatt@intel.com</a>>
Reviewed-by: Chris Wilson <<a href="mailto:chris@chris-wilson.co.uk">chris@chris-wilson.co.uk</a>>
Signed-off-by: Chris Wilson <<a href="mailto:chris@chris-wilson.co.uk">chris@chris-wilson.co.uk</a>>
Link:
<a href="https://patchwork.freedesktop.org/patch/msgid/20191115231538.1249-1-don.hiatt@intel.com">https://patchwork.freedesktop.org/patch/msgid/20191115231538.1249-1-don.hiatt@intel.com</a></pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
<li>You are the QA Contact for the bug.</li>
</ul>
</body>
</html>