[PATCH 13/43] drm/i915: Add a simple fence selftest to i915_gem_request

Chris Wilson chris at chris-wilson.co.uk
Sun Dec 4 21:16:51 UTC 2016


Do a quick selftest on in the interoperability of dma_fence_wait on a
i915_gem_request.

Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
---
 drivers/gpu/drm/i915/i915_gem_request.c | 53 +++++++++++++++++++++++++++++++++
 1 file changed, 53 insertions(+)

diff --git a/drivers/gpu/drm/i915/i915_gem_request.c b/drivers/gpu/drm/i915/i915_gem_request.c
index 87fa8fc436ac..2d125f0041f4 100644
--- a/drivers/gpu/drm/i915/i915_gem_request.c
+++ b/drivers/gpu/drm/i915/i915_gem_request.c
@@ -1487,10 +1487,63 @@ static int igt_add_request(void *ignore)
 	return err;
 }
 
+static int igt_fence_wait(void *ignore)
+{
+	struct drm_i915_private *i915;
+	struct drm_i915_gem_request *request;
+	int err = -ENOMEM;
+
+	i915 = mock_device();
+	if (!i915)
+		goto out;
+
+	mutex_lock(&i915->drm.struct_mutex);
+	request = i915_gem_request_alloc(i915->engine[RCS],
+					 i915->kernel_context);
+	if (!request) {
+		mutex_unlock(&i915->drm.struct_mutex);
+		goto out_device;
+	}
+
+	err = -EINVAL;
+	if (dma_fence_is_signaled(&request->fence)) {
+		pr_err("fence signaled before submit!\n");
+		i915_add_request(request);
+		mutex_unlock(&i915->drm.struct_mutex);
+		goto out_device;
+	}
+
+	mock_request_set_delay(request, HZ);
+	i915_add_request(request);
+	mutex_unlock(&i915->drm.struct_mutex);
+
+	if (dma_fence_wait_timeout(&request->fence, false, 1) != -ETIME) {
+		pr_err("fence wait success after submit (expected timeout)!\n");
+		goto out_device;
+	}
+
+	if (dma_fence_wait_timeout(&request->fence, false, 2*HZ) <= 0) {
+		pr_err("fence wait timed out (expected success)!\n");
+		goto out_device;
+	}
+
+	if (!dma_fence_is_signaled(&request->fence)) {
+		pr_err("fence unsignaled after waiting!\n");
+		goto out_device;
+	}
+
+	err = 0;
+out_device:
+	mock_device_free(i915);
+out:
+	return err;
+}
+
 int i915_gem_request_selftest(void)
 {
 	static const struct i915_subtest tests[] = {
 		SUBTEST(igt_add_request),
+		SUBTEST(igt_fence_wait),
 	};
 
 	return i915_subtests(tests, NULL);
-- 
2.10.2



More information about the Intel-gfx-trybot mailing list