[PATCH 14/45] drm/i915: Add selftests for i915_gem_request

Chris Wilson chris at chris-wilson.co.uk
Mon Dec 5 07:54:00 UTC 2016


Simple starting point for adding seltests for i915_gem_request, first
mock a device (with engines and contexts) that allows us to construct
and execute a request, along with waiting for the request to complete.

Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
---
 drivers/gpu/drm/i915/i915_gem_request.c | 287 ++++++++++++++++++++++++++++++++
 drivers/gpu/drm/i915/i915_selftests.h   |   1 +
 2 files changed, 288 insertions(+)

diff --git a/drivers/gpu/drm/i915/i915_gem_request.c b/drivers/gpu/drm/i915/i915_gem_request.c
index 881bed5347fb..448b9f9c0d5a 100644
--- a/drivers/gpu/drm/i915/i915_gem_request.c
+++ b/drivers/gpu/drm/i915/i915_gem_request.c
@@ -1208,3 +1208,290 @@ void i915_gem_retire_requests(struct drm_i915_private *dev_priv)
 	for_each_engine(engine, dev_priv, id)
 		engine_retire_requests(engine);
 }
+
+#if IS_ENABLED(CONFIG_DRM_I915_SELFTEST)
+#include "i915_selftest.h"
+
+struct mock_request {
+	struct drm_i915_gem_request request;
+	struct timer_list timer;
+};
+
+static void mock_seqno_advance(struct intel_engine_cs *engine, u32 seqno)
+{
+	if (i915_seqno_passed(intel_engine_get_seqno(engine), seqno))
+		return;
+
+	intel_write_status_page(engine, I915_GEM_HWS_INDEX, seqno);
+	intel_engine_wakeup(engine);
+}
+
+static int mock_context_pin(struct intel_engine_cs *engine,
+			    struct i915_gem_context *ctx)
+{
+	return 0;
+}
+
+static void mock_context_unpin(struct intel_engine_cs *engine,
+			       struct i915_gem_context *ctx)
+{
+}
+
+static int mock_request_alloc(struct drm_i915_gem_request *request)
+{
+	request->ring = request->engine->buffer;
+	return 0;
+}
+
+static int mock_emit_flush(struct drm_i915_gem_request *request,
+			   unsigned int flags)
+{
+	return 0;
+}
+
+static void mock_emit_breadcrumb(struct drm_i915_gem_request *request,
+				 u32 *flags)
+{
+}
+
+static void timer_request_complete(unsigned long data)
+{
+	struct drm_i915_gem_request *request = (typeof(request))data;
+
+	mock_seqno_advance(request->engine, request->global_seqno);
+}
+
+static void mock_submit_request(struct drm_i915_gem_request *request)
+{
+	struct mock_request *mock =
+		container_of(request, typeof(*mock), request);
+
+	i915_gem_request_submit(request);
+
+	setup_timer(&mock->timer,
+		    timer_request_complete,
+		    (unsigned long)request);
+	mod_timer(&mock->timer, jiffies + mock->timer.expires);
+}
+
+static void mock_request_set_delay(struct drm_i915_gem_request *request,
+				   unsigned long delay)
+{
+	struct mock_request *mock =
+		container_of(request, typeof(*mock), request);
+
+	mock->timer.expires = delay;
+}
+
+static struct intel_ring *mock_ring(struct intel_engine_cs *engine)
+{
+	struct intel_ring *ring;
+
+	ring = kzalloc(sizeof(*ring) + 4096, GFP_KERNEL);
+	if (!ring)
+		return NULL;
+
+	ring->engine = engine;
+	ring->size = 4096;
+	ring->effective_size = ring->size;
+	ring->vaddr = (void *)(ring + 1);
+
+	INIT_LIST_HEAD(&ring->request_list);
+	ring->last_retired_head = -1;
+	intel_ring_update_space(ring);
+
+	return ring;
+}
+
+static struct intel_engine_cs *mock_engine(struct drm_i915_private *i915,
+					   const char *name)
+{
+	struct intel_engine_cs *engine;
+	static int id;
+
+	engine = kzalloc(sizeof(*engine) + 4096, GFP_KERNEL);
+	if (!engine)
+		return NULL;
+
+	engine->buffer = mock_ring(engine);
+	if (!engine->buffer) {
+		kfree(engine);
+		return NULL;
+	}
+
+	/* minimal engine setup for requests */
+	engine->i915 = i915;
+	engine->name = name;
+	engine->id = id++;
+	engine->status_page.page_addr = (void *)(engine + 1);
+
+	engine->context_pin = mock_context_pin;
+	engine->context_unpin = mock_context_unpin;
+	engine->request_alloc = mock_request_alloc;
+	engine->emit_flush = mock_emit_flush;
+	engine->emit_breadcrumb = mock_emit_breadcrumb;
+	engine->submit_request = mock_submit_request;
+
+	engine->timeline = &i915->gt.global_timeline.engine[engine->id];
+
+	/* minimal breadcrumbs init */
+	spin_lock_init(&engine->breadcrumbs.lock);
+	engine->breadcrumbs.mock = true;
+
+	return engine;
+}
+
+static void mock_engine_free(struct intel_engine_cs *engine)
+{
+	if (engine->last_context)
+		engine->context_unpin(engine, engine->last_context);
+
+	kfree(engine->buffer);
+	kfree(engine);
+}
+
+static struct i915_gem_context *mock_context(struct drm_i915_private *i915)
+{
+	struct i915_gem_context *ctx;
+
+	ctx = kzalloc(sizeof(*ctx), GFP_KERNEL);
+	if (!ctx)
+		return NULL;
+
+	ctx->i915 = i915;
+
+	return ctx;
+}
+
+static void mock_context_free(struct i915_gem_context *ctx)
+{
+	kfree(ctx);
+}
+
+static void mock_retire_work_handler(struct work_struct *work)
+{
+}
+
+static void mock_idle_work_handler(struct work_struct *work)
+{
+}
+
+static struct drm_i915_private *mock_device(void)
+{
+	struct drm_i915_private *i915;
+
+	i915 = kzalloc(sizeof(*i915), GFP_KERNEL);
+	if (!i915)
+		return NULL;
+
+	mutex_init(&i915->drm.struct_mutex);
+
+	init_waitqueue_head(&i915->gpu_error.wait_queue);
+	init_waitqueue_head(&i915->gpu_error.reset_queue);
+
+	INIT_DELAYED_WORK(&i915->gt.retire_work, mock_retire_work_handler);
+	INIT_DELAYED_WORK(&i915->gt.idle_work, mock_idle_work_handler);
+
+	INIT_LIST_HEAD(&i915->gt.timelines);
+	i915->gt.awake = true;
+
+	mutex_lock(&i915->drm.struct_mutex);
+	i915_gem_timeline_init__global(i915);
+	i915_gem_timeline_init(i915, &i915->ggtt.base.timeline, "mock");
+	mutex_unlock(&i915->drm.struct_mutex);
+
+	i915->requests = KMEM_CACHE(mock_request,
+				    SLAB_HWCACHE_ALIGN |
+				    SLAB_RECLAIM_ACCOUNT |
+				    SLAB_DESTROY_BY_RCU);
+	if (!i915->requests)
+		goto err_device;
+
+	i915->dependencies = KMEM_CACHE(i915_dependency,
+					SLAB_HWCACHE_ALIGN |
+					SLAB_RECLAIM_ACCOUNT);
+	if (!i915->dependencies)
+		goto err_requests;
+
+	mkwrite_device_info(i915)->ring_mask = BIT(0);
+	i915->engine[RCS] = mock_engine(i915, "mock");
+	if (!i915->engine[RCS])
+		goto err_dependencies;
+
+	i915->kernel_context = mock_context(i915);
+	if (!i915->kernel_context)
+		goto err_engine;
+
+	return i915;
+
+err_engine:
+	mock_engine_free(i915->engine[RCS]);
+err_dependencies:
+	kmem_cache_destroy(i915->dependencies);
+err_requests:
+	kmem_cache_destroy(i915->requests);
+err_device:
+	kfree(i915);
+	return NULL;
+}
+
+static void mock_device_free(struct drm_i915_private *i915)
+{
+	mutex_lock(&i915->drm.struct_mutex);
+	WARN_ON(i915_gem_wait_for_idle(i915, I915_WAIT_LOCKED));
+	i915_gem_retire_requests(i915);
+	mutex_unlock(&i915->drm.struct_mutex);
+
+	cancel_delayed_work_sync(&i915->gt.retire_work);
+	cancel_delayed_work_sync(&i915->gt.idle_work);
+
+	mock_engine_free(i915->engine[RCS]);
+	mock_context_free(i915->kernel_context);
+
+	mutex_lock(&i915->drm.struct_mutex);
+	i915_gem_timeline_fini(&i915->ggtt.base.timeline);
+	i915_gem_timeline_fini(&i915->gt.global_timeline);
+	mutex_unlock(&i915->drm.struct_mutex);
+
+	kmem_cache_destroy(i915->dependencies);
+	kmem_cache_destroy(i915->requests);
+
+	kfree(i915);
+}
+
+static int igt_add_request(void *ignore)
+{
+	struct drm_i915_private *i915;
+	struct drm_i915_gem_request *request;
+	int err = -ENOMEM;
+
+	i915 = mock_device();
+	if (!i915)
+		goto out;
+
+	mutex_lock(&i915->drm.struct_mutex);
+	request = i915_gem_request_alloc(i915->engine[RCS],
+					 i915->kernel_context);
+	if (!request)
+		goto out_unlock;
+
+	mock_request_set_delay(request, HZ/10);
+	i915_add_request(request);
+
+	err = 0;
+out_unlock:
+	mutex_unlock(&i915->drm.struct_mutex);
+	mock_device_free(i915);
+out:
+	return err;
+}
+
+int i915_gem_request_selftest(void)
+{
+	static const struct i915_subtest tests[] = {
+		SUBTEST(igt_add_request),
+	};
+
+	return i915_subtests(tests, NULL);
+}
+#endif
diff --git a/drivers/gpu/drm/i915/i915_selftests.h b/drivers/gpu/drm/i915/i915_selftests.h
index 9562ec81c781..ff35d2a3f80d 100644
--- a/drivers/gpu/drm/i915/i915_selftests.h
+++ b/drivers/gpu/drm/i915/i915_selftests.h
@@ -8,5 +8,6 @@
  *
  * Tests are executed in reverse order by igt/drv_selftest
  */
+selftest(requests, i915_gem_request_selftest)
 selftest(breadcrumbs, intel_breadcrumbs_selftest)
 selftest(sanitycheck, i915_selftest_sanitycheck) /* keep last */
-- 
2.10.2



More information about the Intel-gfx-trybot mailing list