[RFC 1/1] drm/i915: Print forcewake domain wake counts before reading register

Chris Wilson chris at chris-wilson.co.uk
Thu Dec 15 10:09:22 UTC 2016


On Thu, Dec 15, 2016 at 03:11:22PM +0530, Sagar Arun Kamble wrote:
> Since wake count is released asynchronously, *drpc_info output indicates
> blitter wake count to be 1. Print these wake counts before reading
> registers in *drpc_info.
> Or should we remove these since there is already another debugfs
> i915_forcewake_domains?

I don't mind there being duplicate information between files. Each file
tends to be a collection of information for debugging one aspect of the
driver, and as such having that information together in an almost atomic
form is definitely useful and preferred.

Patch looks harmless.

> Cc: Chris Wilson <chris at chris-wilson.co.uk>
> Signed-off-by: Sagar Arun Kamble <sagar.a.kamble at intel.com>
Acked-by: Chris Wilson <chris at chris-wilson.co.uk>
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


More information about the Intel-gfx-trybot mailing list